Repository navigation
Fix native floating-point frame decoding - #441
Merged
CPBridge merged 1 commit intoJul 26, 2026
Merged
Conversation
Signed-off-by: kyinhub <kevinpyin@gmail.com>
yinkev
force-pushed
the
bugfix/lazy-float-pixel-frames
branch
from
July 26, 2026 02:23
e917d14 to
11542a5
Compare
CPBridge
approved these changes
Jul 26, 2026
CPBridge
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for catching this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #436.
Summary
FloatPixelDataandDoubleFloatPixelDataframes throughImageFileReaderBitsStoredandPixelRepresentationattributes for floating-point pixel modulesRoot cause
ImageFileReaderdetected floating-point pixel tags while scanning the file, butread_frame()discarded that information. It then required integer Pixel Data attributes and calleddecode_frame()with its integer default keyword, so valid floating-point DICOM images failed before decoding.Validation
upstream/masterwith missingBitsStoredpython -B -m pytest tests/test_io.py::TestImageFileReader::test_read_float_pixel_data -qtests/test_io.py: 111 passed, 9 skippedpytest --flake8: 2,022 passed, 178 expected optional-dependency skipspython -B -m flake8 src/highdicom/io.py tests/test_io.pygit diff --check