Conversation
- Updated `practice_unit` type to support `None` values. Signed-off-by: Illustar0 <me@illustar0.com>
Signed-off-by: Illustar0 <me@illustar0.com>
* fix: fail on invalid schedule datetimes * fix: narrow portal config fallback
- Replaced `DAYS` and `UNITS` with `ClassVar` to ensure immutability. Signed-off-by: Illustar0 <me@illustar0.com>
* refactor: add alias generation and deprecation warnings - Added `ConfigDict` with `alias_generator` to models for camelCase support. - Introduced warnings for deprecated snake_case property usage. - Updated `OnlineDevice` properties to align with new alias schema. - Applied changes to `AuthResult` and `PortalInfo`. Signed-off-by: Illustar0 <me@illustar0.com> * docs: update `OnlineDevice` examples to use snake_case - Updated code examples in `network.md` to reflect snake_case fields. - Added a note explaining the deprecation of camelCase properties. Signed-off-by: Illustar0 <me@illustar0.com> --------- Signed-off-by: Illustar0 <me@illustar0.com>
Signed-off-by: Illustar0 <me@illustar0.com>
- Updated time conversion methods from `py_datetime` to `to_stdlib`. - Applied changes to `start_time`, `end_time`, and `dtstamp` fields for consistency. Signed-off-by: Illustar0 <me@illustar0.com>
- Updated utility function to use `inspect.iscoroutinefunction` for coroutine checks. - Ensures compatibility and correctness when determining coroutine functions. Signed-off-by: Illustar0 <me@illustar0.com>
- Replaced `<font>` tag with `<span>` for consistency. - Applied inline styles for color and font size directly. Signed-off-by: Illustar0 <me@illustar0.com>
- Fixed `exp` handling by converting to float before decoding timestamps. - Added `assert` statements to validate public key initialization. Signed-off-by: Illustar0 <me@illustar0.com>
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthrough本PR对ZZU.Py的类型安全性和数据规范化进行了全面升级。主要包括:网络模型从驼峰命名改为snake_case并配置Pydantic别名、认证流程的JWT和公钥验证更新、Portal发现URL校验增强、whenever库日期时间处理改进,以及工具函数的优化。 Changes类型安全与规范化
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
发布说明
API 变更
login_time、session_id);旧属性名仍可访问但会触发弃用警告。Bug 修复
文档