Add support for AppData log files and update menu entry#257
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves how KKManager locates and opens game log files, expanding detection to include logs written under AppData (LocalLow) and updating the UI text to reflect that multiple log files may be opened/collected.
Changes:
- Refactors log-file discovery into
InstallDirectoryHelper.FindLogFiles(...)and reuses it for both “Open log” and “Collect game debug info”. - Adds LocalLow (AppData) log discovery via a new
PathTools.GetAppDataLocalLowPath()helper. - Updates the “Open game log” menu text/tooltip to reflect multi-log behavior.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/KKManager/Windows/MainWindow.resx | Updates menu text/tooltip for opening logs (and resource ordering). |
| src/KKManager/Windows/MainWindow.Designer.cs | Designer reordering for menu items/separators consistent with resx updates. |
| src/KKManager.Core/Util/PathTools.cs | Adds Known Folder lookup for AppData\LocalLow. |
| src/KKManager.Core/Functions/InstallDirectoryHelper.cs | Introduces shared log discovery logic and AppData-relative mappings; updates OpenLog to open multiple files. |
| src/KKManager.Core/Functions/DebugInfo.cs | Switches debug-info log collection to the new shared log discovery method. |
Files not reviewed (1)
- src/KKManager/Windows/MainWindow.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored and improved log file detection logic for both the "open log" and "gather debug info" menu items.