feat: add parallel price acquisition - #19
Open
OneSpir1t wants to merge 1 commit into
Open
Conversation
Author
|
Slightly restructured code and fixed tabulation issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some improvements that were made:
Explanation:
In the original implementation, when extracting prices, the main flow was blocked, which led to freezes and, as a result, a negative experience of using the mod (especially with Fika, #11). In addition, extracting prices from Flea was determined by the parameter "Enable qiuck sale to flea", which is not entirely obvious, so it was moved to a separate setting. In general, you can see for yourself how it works now.
P.S. The setting for parallel price extraction is disabled by default