Replace unicode_hack.js w/ regex uni chars, ship THIRD-PARTY-LICENSES.md at the package root - #406
Draft
damyanpetev wants to merge 2 commits into
Conversation
damyanpetev
marked this pull request as draft
September 10, 2026 06:33
damyanpetev
added this pull request to stack #407
September 10, 2026 06:34
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new unanchored regexes alter first-character classification behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Replaces the legacy Unicode implementation with native regex properties and packages dependency licenses at the NuGet package root.
Changes:
- Uses Unicode property escapes for character classification.
- Moves and packages the generated third-party license manifest.
- Updates static-asset validation and generated-file exclusions.
File summaries
| File | Description |
|---|---|
vite.config.mts |
Moves the generated license manifest outside wwwroot. |
tests/js/static-web-assets.test.mjs |
Verifies the manifest’s new location. |
src/src/ig/igniteui-core/stringExtended.ts |
Replaces legacy Unicode tables with regexes. |
src/IgniteUI.Blazor.Lite.csproj |
Adds the manifest to the NuGet package root. |
.gitignore |
Ignores the generated manifest. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
damyanpetev
force-pushed
the
dpetev/unicode-cleaup-thuird-party-notices
branch
from
September 10, 2026 07:17
e0e6ec7 to
b5f8d1d
Compare
damyanpetev
force-pushed
the
dpetev/unicode-cleaup-thuird-party-notices
branch
from
September 10, 2026 09:04
b5f8d1d to
7296a34
Compare
damyanpetev
force-pushed
the
dpetev/unicode-cleaup-thuird-party-notices
branch
from
September 10, 2026 10:39
7296a34 to
3eace90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
igniteui-core/stringExtended.tscarriedunicode_hack.js, a 2010-era polyfill that emulated\p{…}regex escapes with hand-generated Unicode 6.x character tables. Native property escapes have been in every supported engine since ES2018, and the tables were stale (hundreds of misclassified BMP code points per category, no astral coverage).api.jsmodule #404 introduced was written intowwwroot, so it was packed and served as a static web asset. It is package documentation, not something a page should fetch.What changed
isLetter,isLetterOrDigit,isDigit,isNumber) are one-line/\p{…}/utests; the tables, the translator,unicode_hackandnetRegexToJSare deleted. The core chunk shrinks by about 11 KB gzip and the in-source legal notice is gone, so thenpm testassertion that guarded it has nothing left to check.THIRD-PARTY-LICENSES.mdmoves to the NuGet package root next to LICENSE and README. Rolldown only emits insideoutDir, so the vite build moves the file next to the csproj incloseBundle, and the csproj packs it when present..gitignorecovers it likewwwroot.Verification
npm run build,npm test, and the .NET suite pass.dotnet packlisting: the manifest is at the package root and absent fromstaticwebassets/.🤖 Generated with Claude Code