Fix fullscreen in Chromium release builds - #2066
Merged
Merged
Conversation
javifernandez
approved these changes
Sep 2, 2026
Minification was never enabled for Chromium builds, among other things, because video fullscreen (YouTube, Vimeo...) didn't work. No error was shown but clicking on the fullscreen buttons didn't just work. The problem was that TabImpl object holds a private TabWebContentsDelegate which is written once but never read. Chromium keeps only a weak global ref to that Java object, so this field is the only thing keeping it alive. R8's optimizer removes write-only fields, so the delegate gets garbage collected, and from then on WebContentsDelegateAndroid::EnterFullscreenModeForTab finds a dead weak ref and returns without calling Java. That bail out return no exception and no log is recorded. The requestFullscreen() promise just hangs forever, that's the reason why nothing was fullscreen'ed. The problem was actually worst as not only the delegate was removed, so it was the WebContents observer for example which is crucial for interacting with web content. Fixes #2047
svillar
force-pushed
the
chromium_fullscreen_minify
branch
from
September 2, 2026 14:16
2bbe5a9 to
68ee3f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual fix is just the second commit but we're including the first one (part of another PR) because otherwise there would be conflicts in the proguard rules file.
Fixes #2047