[Chromium] Fix a startup crash with minification on - #2065
Merged
Conversation
Chromium's WindowLayoutInfoListener passes a lambda implementing the platform provided Consumer interface to the system. R8 could not see that the desugared lambda's accept(Object) overrides anything and stripped it, so startup crashes with AbstractMethodError. A classic -keep* rule can fix that because R8 synthesises the lambda class after keep rules are matched. The actual fix is adding an androidx.window.extensions.core:core dependency in build.gradle. Apart from that, we're groupping the backend specific rules together, so that it'd be easier to identify which rules are required by Chromium and which ones are Gecko only (actually the rules apply to both but they are not strictly needed for both).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium's WindowLayoutInfoListener passes a lambda implementing the platform provided Consumer interface to the system. R8 could not see that the desugared lambda's accept(Object) overrides anything and stripped it, so startup crashes with AbstractMethodError. A classic -keep* rule can fix that because R8 synthesises the lambda class after keep rules are matched. The actual fix is adding an
androidx.window.extensions.core:core dependency in build.gradle.
Apart from that, we're groupping the backend specific rules together, so that it'd be easier to identify which rules are required by Chromium and which ones are Gecko only (actually the rules apply to both but they are not strictly needed for both).