Add a "Close other tabs" button to the tabs panel - #2055
Merged
Conversation
svillar
requested changes
Aug 20, 2026
| mUnselectTabs.setVisibility(View.GONE); | ||
| mCloseTabsAllButton.setVisibility(View.VISIBLE); | ||
| mCloseOtherTabsButton.setVisibility(View.VISIBLE); | ||
| mCloseOtherTabsButton.setEnabled(!SessionStore.get().getInactiveSessions(mPrivateMode).isEmpty()); |
Member
There was a problem hiding this comment.
Let's do the same as the others and change visibility instead of disabling
Contributor
Author
There was a problem hiding this comment.
Should it be shown whenever the other buttons are shown or hidden when there's nothing to close?
Member
There was a problem hiding this comment.
The logic to show it was fine (checking inactive sessions), the only thing to change is that the condition should change the visibility status not whether it's enabled/disabled
The button sits in the selection bar next to "Close all" and closes every tab that is not currently shown in a window. WebExtension sessions are never closed. The button is hidden when there is nothing to close.
monofunc
force-pushed
the
feature/close-other-tabs
branch
from
August 21, 2026 13:17
0a08cab to
ea1ea34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The button sits in the selection bar next to "Close all" and closes every tab that is not currently shown in a window. WebExtension sessions are never closed. The button is hidden when there is nothing to close.
#2010 (comment)