Skip to content

Do not compare flavor strings with == #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svillar merged 1 commit into from
Aug 17, 2026
+2 −2
Merged

Do not compare flavor strings with == #2050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/common/shared/com/igalia/wolvic/browser/SettingsStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public static WindowSizePreset fromValues(int width, int height) {
public final static int POINTER_COLOR_DEFAULT_DEFAULT = Color.parseColor("#FFFFFF");
public final static String ENV_DEFAULT = "cyberpunk";
public final static int MSAA_DEFAULT_LEVEL = 1;
public final static boolean AUDIO_ENABLED = BuildConfig.FLAVOR_backend == "chromium";
public final static boolean AUDIO_ENABLED = BuildConfig.FLAVOR_backend.equals("chromium");
public final static boolean LATIN_AUTO_COMPLETE_ENABLED = false;
public final static boolean WINDOW_MOVEMENT_DEFAULT = false;
public final static @TabsLocation int TABS_LOCATION_DEFAULT = TABS_LOCATION_TRAY;
Expand Down
2 changes: 1 addition & 1 deletion app/src/common/shared/com/igalia/wolvic/browser/engine/Session.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ public CompletableFuture<Void> captureBackgroundBitmap(int displayWidth, int dis
// FIXME: calling acquireDisplay() is not well supported in the Chromium backend because
// that method incorrectly does some extra work handling widgets. Disable the bitmap
// capture in the meantime (it was not working anyway yet).
if (mState.mSession == null || !mFirstContentfulPaint || BuildConfig.FLAVOR_backend == "chromium") {
if (mState.mSession == null || !mFirstContentfulPaint || BuildConfig.FLAVOR_backend.equals("chromium")) {
return CompletableFuture.completedFuture(null);
}
Surface captureSurface = BitmapCache.getInstance(mContext).acquireCaptureSurface(displayWidth, displayHeight);
Expand Down
Loading