Do not compare strings with == - #2030
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The code change is small and correct; the only concern is PR scope/title clarity rather than functional correctness.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Updates a string comparison in the Chromium runtime initialization path to avoid reference-equality checks and ensure the ABI flavor is compared by value before applying an x64-specific Vulkan disablement switch.
Changes:
- Replace
==string comparison with.equals("x64")forBuildConfig.FLAVOR_abiwhen deciding to disable Vulkan.
File summaries
| File | Description |
|---|---|
| app/src/common/chromium/com/igalia/wolvic/browser/api/impl/RuntimeImpl.java | Uses value-based string comparison for ABI flavor gating of a Chromium command-line switch. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
javifernandez
approved these changes
Aug 14, 2026
svillar
force-pushed
the
fix_string_comparison
branch
from
August 14, 2026 15:58
aa10611 to
f906ac2
Compare
The == operator compares references, and could indeed return true even if contents match. Replace it by equals which in the case of Strings compares contents.
svillar
force-pushed
the
fix_string_comparison
branch
from
August 14, 2026 15:59
f906ac2 to
50a3206
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The == operator compares references, and could indeed return true even if contents match. Replace it by equals which in the case of Strings compares contents.