Remove some unused and problematic gstreamer modules - #267
Draft
TingPing wants to merge 2 commits into
Draft
Conversation
TingPing
requested review from
aperezdc,
clopez and
nikolaszimmermann
as code owners
August 13, 2026 19:48
TingPing
changed the title
TingPing
force-pushed
the
extra-gstreamer-modules
branch
from
August 13, 2026 19:50
4b2ccc8 to
9d5cc19
Compare
This requires root to install so errors with `jhbuild make`
AFAICT this isn't used anywhere and is for example not enabled in Ubuntu's package. This was causing confusion because CI would build the submodule for the library.
TingPing
force-pushed
the
extra-gstreamer-modules
branch
from
August 13, 2026 19:51
9d5cc19 to
2d9a4ea
Compare
TingPing
marked this pull request as draft
August 13, 2026 21:39
nikolaszimmermann
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ptp-helper expects being installed as root which errors with
jhbuild makelibvmaf is built as an automatic submodule in CI, but
jhbuild makewasn't building it. Either way it doesn't appear to be used.