Rewrite url to guzzle#351
Open
TheSyscall wants to merge 2 commits into
Open
Conversation
The icinga `Url::fromPath` method builds a path for the use in a icingaweb, stripping scheme and host if it matches the current request. This is undesired behavior for backend use. Since the `GraphiteWebClient` already uses GuzzleHttp it is logical to use the more versatile `UriInterface` interface and `Uri` class.
This class was used to get the `Url::fromPath` method into never stripping the scheme and host parts, and forcing the URL to always be external, even if the configured URL matches the current request url. With the swtich to the `UriInterface` this workaround is no longer required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphiteWebClientusedIcinga\Web\Urlto manage the Graphite Web base URL.Url::fromPath()requires aFakeSchemeRequestworkaround to prevent it from treating the Graphite URL as an internal Icinga Web path. A subsequent change toUrl::fromPath()added scheme validation that rejects the fake scheme value, breaking any Graphite URL without an explicit port.GraphiteWebClienthas no inherent dependency on Icinga's web layer. This replacesIcinga\Web\UrlwithGuzzleHttp\Psr7\Uri, already available via Guzzle, typed againstPsr\Http\Message\UriInterface, and removesFakeSchemeRequestentirely.fixes #350