reduce container memory#214
Open
n35k3nd1r wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce memory retention during synchronization and container log processing.
This change removes two sources of unnecessary retained state during startup and ongoing sync:
Motivation
On large Kubernetes/OpenShift clusters, retaining previous database state in memory can grow significantly. Container logs can hold up to the configured maximum log length per container, and the generic sync warmup previously added complete database objects to the informer store before the real Kubernetes cache sync completed.
This can increase sustained heap usage during large-cluster operation and startup synchronization.
Changes
strings.ToValidUTF8()before truncating.Expected Impact
The daemon retains less historical synchronization state in memory. Container log memory is reduced from roughly all known/running containers times the maximum stored log length to only currently executing log sync jobs plus normal DB/Kubernetes client overhead.
The sync warmup also avoids keeping full DB objects in the informer store and instead tracks only keys and UUIDs needed to identify stale objects.