[BUGFIX] Check BackendUtility::getRecord before using it in array_merge

[mikelwohlschlegel]

This checks BackendUtility::getRecord before using it in array_merge to avoid an exception.

We had the following problem:
There seems to be a difference in processing a history rollback between v11 und v12.

Steps to reproduce:

• Add a new container to a page
• Add a new content element to the same page
• Move the new content element into the new container
• Go back to the history and rollback ALL this steps

v11 --> WORKS
v12 --> EXCEPTION

While step debugging, I found out that $datamap['tt_content'] in

content_defender/Classes/Hooks/DatamapDataHandlerHook.php

Line 34 in dab78e7

if (empty($datamap['tt_content']) || $dataHandler->bypassAccessCheckForRecords) {

is empty in v11 and not empty in v12.
My guess is, that v12 processes every single step in v12, while v11 just deletes the newly added elements (not proofed).

I'm not sure if this can maybe cause some side affects? What is the intention of merging the arrays here?

[IchHabRecht]

it seems you doing the same thing twice now?

[mikelwohlschlegel]

@IchHabRecht You're right. I forgot to delete the original line. The commit is updated. Thanks.

[Bunnyfield]

BackendUtility::getRecord() is typed to return array|null, so this call site needs the guard regardless of how the datamap ends up with an unresolved reference. We hit the same crash independently via a different workflow in L10nmgr, so this fix should be merged.

[moritz-ngo]

BackendUtility::getRecord() is typed to return array|null, so this call site needs the guard regardless of how the datamap ends up with an unresolved reference. We hit the same crash independently via a different workflow in L10nmgr, so this fix should be merged.

This PR works like charm, would be great if it could be merged

[doemedia]

I had the same issue and use the patch from moritz

[mikelwohlschlegel]

Hi @IchHabRecht
three upvotes in the meanwhile. We use this patch in production since about one year. Can you think about merging it? It seems to help others...

[IchHabRecht]

Hi @mikelwohlschlegel and others,

Thank you for all your comments. I hope you understand that with the release of TYPO3 v14 and the integration of this functionality into the TYPO3 core, I will no longer be able to continue maintaining and supporting the content_defender extension in my spare time.

If there is still a need for a maintained version of content_defender, please feel free to get in touch with me so we can discuss possible options.

[mikelwohlschlegel]

@IchHabRecht Thanks for your reply. This will be fully integrated into the core in v14? I did not know that. I guess, we can live with a patch till v14 then. Thanks for your effort on this.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud