[FEATURE] gray badge - #125
Conversation
|
Hi @IchHabRecht Thank you very much for your effort. I will start a review to ask some minor questions. |
|
|
||
| .t3-cd-badge-container { | ||
| position: relative; | ||
| .t3js-page-column .t3-cd-badge-container[data-maxitems="0"] .t3-page-ce .t3js-page-new-ce, |
There was a problem hiding this comment.
If I understand the CSS correctly for a full column there wouldn't be any badge anymore. But one of the main purposes is to tell the editor that there is a limit and it is reached.
There was a problem hiding this comment.
No, the Line 3-12 just removes the «new content-element» Button not the badge.
Line 8-12 is a fix, to prevent the shifting of the Drop area if the button is hidden.
The badge is always visible. We just hide it if there is no maxitems property in the backendlayout configuration.
| position: relative; | ||
| } | ||
|
|
||
| .t3-cd-badge { |
There was a problem hiding this comment.
Did you tested the layout in all TYPO3 versions yet?
There was a problem hiding this comment.
i say it in German – "verdammt – da war noch was 😳"
I keep you updated after testing
|
Hi @IchHabRecht we tested, the branch in a T3 10, 11 and 12. |
|
Thank you very much for your help. I will review the changes as soon as I find some time. |
3 participants
Hi @IchHabRecht
I made the Style of the badge and fixed some issues with the drag and drop area.
I tried to place the badge without an absolute position, but i had to change too much on the wrapping element styles.
So i went back to the absolute positioning. Because of that the badge is placed in front of the column title.
Depending of the length of the badge, i gave a «padding-left» to the column title. Because of that i set a limit to the maxitem variable. If there is a value over 99, i write a string «+99» to the badge.
Greets Ben