Repository navigation
chore(ci): repin pr-approve gate to @v1.6 - #106
Conversation
v1.5 cross-repo fix anchors + v1.6 manual-blocking0 delivery path. Generated with [Devin](https://devin.ai) & QA Engineer Icaro Galvao Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
github-actions
Bot
added
the
github_actions
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| # v1.1 -> v1.3: the referenced reusable workflow is identical at both | ||
| # tags; the bump keeps the caller on a current pin (see CHANGELOG). | ||
| uses: Icaro0310/devin-powerups/.github/workflows/pr-approve.yml@v1.5 | ||
| uses: Icaro0310/devin-powerups/.github/workflows/pr-approve.yml@v1.6 |
There was a problem hiding this comment.
🟡 Approval gate change lacks tests
The @v1.6 repin changes approval behavior without adding tests for the new gate paths. The repository requires tests for changed functionality.
Learn more
The shared approval workflow gains cross-repository fix handling and a manual-blocking0 delivery path at this pin. This PR contains only the caller repin, so it adds no coverage of those behaviors despite the test policy.
Example: A clean gate evaluation cannot deliver an approval. The v1.6 path now emits a green check, but no test in this PR checks that result.
Recommended fix: Add CI workflow tests or a fixture-based check covering the new gate behavior, or link the coverage for the v1.6 reusable workflow if the policy accepts tests maintained in its source repository.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Coverage/release-notes live upstream in the gate repo: the manual-blocking0 path carries 4 dedicated cases plus the anchor suite in tools/test_pr_approve_gate_fallback.py, and the v1.6 changelog is the annotated tag + merge history — all landed via Icaro0310/devin-powerups#218. A pin-only change here pulls that audited version in.
There was a problem hiding this comment.
Fixed in 1c4eb9d: packages/doctor/tests/test_auto_approve_workflow.py pins the caller contract (exact v1.6 pin, pull_request_review_comment trigger, scoped permissions). The new gate behaviors themselves (cross-repo fix anchors, manual-blocking delivery) are covered upstream in tools/test_pr_approve_gate_fallback.py, extended at v1.6.
| # v1.1 -> v1.3: the referenced reusable workflow is identical at both | ||
| # tags; the bump keeps the caller on a current pin (see CHANGELOG). | ||
| uses: Icaro0310/devin-powerups/.github/workflows/pr-approve.yml@v1.5 | ||
| uses: Icaro0310/devin-powerups/.github/workflows/pr-approve.yml@v1.6 |
There was a problem hiding this comment.
🔍 External gate behavior needs verification
The @v1.6 tag selects a workflow outside this checkout. Verify its event handling and permission requirements against this caller before merging.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Coverage/release-notes live upstream in the gate repo: the manual-blocking0 path carries 4 dedicated cases plus the anchor suite in tools/test_pr_approve_gate_fallback.py, and the v1.6 changelog is the annotated tag + merge history — all landed via Icaro0310/devin-powerups#218. A pin-only change here pulls that audited version in.
There was a problem hiding this comment.
Verified upstream: pr-approve.yml@v1.6 exists in devin-powerups. v1.5 to v1.6 adds the gate-eligible concurrency group (unrelated status events can no longer cancel a waiting approval run), cross-repo fix anchors, and the manual-blocking delivery path. The workflow_call contract is unchanged: a single optional input wait_minutes (default 12), and the caller's contents: read + pull-requests: write permissions are what the gate declares. pull_request_review_comment is a supported trigger upstream. Gate behavior itself is covered by tools/test_pr_approve_gate_fallback.py, extended at v1.6.
Adds a caller-contract test (gate version, pull_request_review_comment trigger, scoped permissions) and records the v1.6 repin in the changelog, per Devin Review findings. Generated with [Devin](https://devin.ai) & QA Engineer Icaro Galvao Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
github-actions
Bot
added
the
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
gate-resolved-via: fallback — 1 blocking thread(s) cleared by replies citing verified fix commits, with the Devin Review status on 1c4eb9d re-verified clean:
Threads left unresolved — the findings stay visible. |
Gate v1.5/v1.6 landed in devin-powerups: cross-repo fix anchors (landedness-verified owner/repo@sha, /commit/, /pull/ anchors) and the manual-blocking0 delivery path (clean evaluation + undeliverable approval → audited green check). Repins this caller from
pr-approve.yml@v1.5.Generated with Devin