fix: stabilize concurrent trace snapshots - #6
Draft
Iams4kura wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
TraceStore.append() updates the in-memory record index while holding _thread_lock, but records() iterated the same dictionary without that lock. A concurrent append could resize the dictionary mid-iteration and raise RuntimeError: dictionary changed size during iteration.
Impact
Readers now observe one stable same-instance snapshot. Large deep copies do not block appends after snapshot references are captured. On-disk JSONL format, cross-process flock behavior, and resume semantics are unchanged.
Validation