Skip to content

bugfix(DatasetDownloadModal): add projectSlug prop to support project… #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepakduggirala wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix(DatasetDownloadModal): add projectSlug prop to support project… #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ui/src/components/project/datasets/DatasetDownloadModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,10 @@ const props = defineProps({
type: Object,
default: () => ({}),
},
projectSlug: {
type: String,
default: null,
},
});
// const emit = defineEmits(["update"]);

Expand All @@ -154,6 +158,10 @@ defineExpose({
});

const downloadURL = computed(() => {
// when projectSlug is present, open the filebrowser within the project context
if(props.projectSlug) {
return `${window.location.origin}/projects/${props.projectSlug}/datasets/${props.dataset.id}/filebrowser`;
}
return `${window.location.origin}/datasets/${props.dataset?.id}/filebrowser`;
});

Expand Down
2 changes: 1 addition & 1 deletion ui/src/components/project/datasets/ProjectDatasetsTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
/>

<!-- Download Modal -->
<DatasetDownloadModal ref="downloadModal" :dataset="datasetToDownload" />
<DatasetDownloadModal ref="downloadModal" :dataset="datasetToDownload" :project-slug="props.project?.slug" />

<!-- Stage Modal -->
<StageDatasetModal
Expand Down