Fix double wrap by NTNDArray - #54
Open
Monarda wants to merge 2 commits into
Open
Conversation
… the desired behaviour; include regression tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug which exists in all the NT types but only blows up in NTNDArray. Because of the implementation it tries to wrap any values passed into open() twice. NTScalars, NTEnums, and NTTables just no-op the second wrap but NTNDArray has a different implementation involving numpy and instead crashes out.
This PR includes a pair of regression tests for
threadandasyncioand the simple fix inserver/raw.py.