Add sliding progress bar on job startup - #1282
Open
MBartkowiakSTFC wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
A minor change to the GUI behaviour: when a job is starting and has not completed a single step, show a scrolling bar in the "Running Jobs" table with the text "STARTING". This is meant mainly to reassure the user that the specific job is being prepared.
Fixes
QTimertoJobEntry, to control the progress bar movement in the starting phase.ProgressDelegateto handle negative values of progress.To test
Start a converter or an analysis run.
Go to the "Running Jobs" tab and check if the "Starting" message is shown on the progress bar before the run starts.
Try pausing and resuming the run before and after the "Starting" message has disappeared. All the buttons from the context menu should work the same as before.