Update tests and make github workflow checkout MDANSE examples and runs scripts. - #1278
Merged
Conversation
ChiCheng45
changed the title
oerc0122
approved these changes
Aug 12, 2026
| path: MDANSE-Examples | ||
|
|
||
| - name: Run tutorial 1 scripts | ||
| working-directory: MDANSE-Examples/tutorials/tutorial1-phase-transition/mdanse_inputs |
Collaborator
There was a problem hiding this comment.
Would it be easier to add a marimo notebook to the examples and run that at some pint?
Collaborator
Author
There was a problem hiding this comment.
I've never used Marimo notebooks before, but they look nice, could be a possibility for the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Added SSF3D regression tests and made the GitHub workflow check out MDANSE examples, run the scripts, and check that the outputs exist.
Closes ISISNeutronMuon/MDANSE-Examples#6
Skips script2_vhfd.py in tutorial 2 as it can take quite some time.
To test
Tests should pass.