Skip to content

'API inconsistency for release time between JsonParser and JsonPrinter#12320

Open
stevenwinship wants to merge 1 commit into
developfrom
11594-release-time-inconsistency-api
Open

'API inconsistency for release time between JsonParser and JsonPrinter#12320
stevenwinship wants to merge 1 commit into
developfrom
11594-release-time-inconsistency-api

Conversation

@stevenwinship

@stevenwinship stevenwinship commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it: The output of JsonPrinter includes "releaseTime" where the input to JsonParser only accepted "releaseDate"

Which issue(s) this PR closes:#11594

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: Included

Additional documentation:

@stevenwinship stevenwinship self-assigned this Apr 10, 2026
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Apr 10, 2026
@stevenwinship stevenwinship added Component: Code Infrastructure formerly "Feature: Code Infrastructure" Consider For Next Release A simple change (eg bug fix) that would be good to prioritize since it has been seen in the wild Feature: API Feature: API Guide Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect labels Apr 10, 2026
@coveralls

coveralls commented Apr 10, 2026

Copy link
Copy Markdown

Coverage Status

Coverage is 25.027%11594-release-time-inconsistency-api into develop. No base build found for develop.

@stevenwinship stevenwinship changed the title ''API inconsistency for release time between JsonParser and JsonPrinter 'API inconsistency for release time between JsonParser and JsonPrinter Apr 10, 2026
@stevenwinship stevenwinship added the FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) label Apr 10, 2026
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Apr 13, 2026
@stevenwinship stevenwinship removed their assignment Apr 13, 2026
@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 67a334d to 28c4875 Compare April 15, 2026 18:40
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 28c4875 to 9aa5071 Compare April 16, 2026 22:37
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 9aa5071 to 6f130f7 Compare April 20, 2026 22:15
@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) label Apr 22, 2026
@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 6f130f7 to 48ed227 Compare April 23, 2026 15:51
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 48ed227 to 85dc51a Compare April 27, 2026 13:11
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 85dc51a to e4b0fed Compare April 30, 2026 13:16
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from e4b0fed to 2066c4b Compare May 2, 2026 14:13
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 5d7a7ca to 74ced46 Compare June 1, 2026 13:59
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 74ced46 to 7ef6472 Compare June 1, 2026 20:50
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 7ef6472 to 779dcec Compare June 3, 2026 15:03
@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 25 FY26 Sprint 25 (2026-06-03 - 2026-06-17) label Jun 3, 2026
@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 779dcec to 36c2676 Compare June 4, 2026 18:07
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship added this to the 6.12 milestone Jun 4, 2026
@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 36c2676 to 6a25ed4 Compare June 8, 2026 13:31
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 6a25ed4 to 782c032 Compare June 9, 2026 20:06
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 782c032 to 3bee1b4 Compare June 15, 2026 21:17
@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 26 FY26 Sprint 26 (2026-06-17 - 2026-07-01) label Jun 18, 2026
@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 3bee1b4 to 5bdacc2 Compare June 22, 2026 17:41
@github-actions

This comment has been minimized.

@rtreacy rtreacy self-assigned this Jun 22, 2026
@rtreacy rtreacy moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Jun 22, 2026
@cmbz cmbz added the FY27 Sprint 1 FY27 Sprint 1 (2026-07-01 - 2026-07-15) label Jul 1, 2026
@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from 5bdacc2 to f703984 Compare July 2, 2026 13:13
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 11594-release-time-inconsistency-api branch from f703984 to 19a1bb3 Compare July 2, 2026 20:45
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11594-release-time-inconsistency-api
ghcr.io/gdcc/configbaker:11594-release-time-inconsistency-api

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@rtreacy rtreacy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude
Overall this is a small, well-targeted, backward-compatible fix with adequate test coverage.
Two minor findings (neither blocking):

  1. The new test shadows the class field sut (the actual JsonParser under test) with an unrelated local String sut = "foobar", and redundantly re-instantiates a parser/mocks instead of reusing the existing sut field from @beforeeach — just a readability/duplication nit.
  2. The release note has two typos ("preferance" → "preference", "continue to truncated" → "continue to be truncated").

@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jul 6, 2026
@rtreacy rtreacy removed their assignment Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Code Infrastructure formerly "Feature: Code Infrastructure" Consider For Next Release A simple change (eg bug fix) that would be good to prioritize since it has been seen in the wild Feature: API Guide Feature: API FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) FY26 Sprint 23 FY26 Sprint 23 (2026-05-06 - 2026-05-20) FY26 Sprint 24 FY26 Sprint 24 (2026-05-20 - 2026-06-03) FY26 Sprint 25 FY26 Sprint 25 (2026-06-03 - 2026-06-17) FY26 Sprint 26 FY26 Sprint 26 (2026-06-17 - 2026-07-01) FY27 Sprint 1 FY27 Sprint 1 (2026-07-01 - 2026-07-15) Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect

Projects

Status: Ready for QA ⏩

Development

Successfully merging this pull request may close these issues.

API inconsistency for release time between JsonParser/JsonPrinter

4 participants