Avoid props drilling multiple repositories#1000
Open
ChengShi-1 wants to merge 12 commits into
Open
Conversation
|
coverage: 97.347% (-0.04%) from 97.385% — AvoidPropsDrillingFileRepo into develop |
ChengShi-1
added
Size: 10
ChengShi-1
moved this from Ready for Review ⏩
to In Progress 💻
in IQSS Dataverse Project
ChengShi-1
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In order to avoid prop-drilling, we could use context to share repository instances. (We have already completed for collection repository and dataset repository)
We could create a custom hook, useRepositories( ) for passing use cases, wrap everything inside its provider component. Storybook and Test files should also be modified to match the same pattern of use context.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
I made changes on following repositories, please check if related pages are working well
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes or changelog update needed for this change?:
Additional documentation: