Guestbook Response DTO Change Username to Name#461
Open
ChengShi-1 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the TypeScript GuestbookResponse model and related tests with the Dataverse API change that returns name (instead of userName) in guestbook responses from GET /api/guestbooks/{guestbookId}/responses, addressing the missing field noted in issue #460.
Changes:
- Renamed
GuestbookResponse.userName→GuestbookResponse.namein the domain model. - Updated unit test fixtures to use
namein mocked guestbook response payloads.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/unit/guestbooks/GuestbooksRepository.test.ts | Updates mocked guestbook response data to use name instead of userName. |
| test/unit/guestbooks/GetGuestbookResponsesByGuestbookId.test.ts | Updates the GuestbookResponse test fixture to use name. |
| src/guestbooks/domain/models/GuestbookResponse.ts | Renames the response field from userName to name in the public model. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
"name" was missing in JSON response to get Guestbook Responses
Changed "userName" in guestbook response to "name" to match the parser in API GET /api/guestbooks/{guestbookId}/responses
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Is there a release notes or changelog update needed for this change?:
Additional documentation: