feat(build_patched_ipa): --bundle-id-suffix flag - #21
Merged
Conversation
Lets a patched IPA install alongside the original app instead of overwriting it, which is what a consumer needs when it wants the stock build and the patched build on the device at the same time. Ported from feat/bundle-id-suffix, which branched before #17-#19 and so never picked up the verify_sites overload resolution its consumer now depends on. Rebuilding the flag on top of develop keeps the two lines from drifting further apart. uv.lock rides along: develop bumped pyproject to 0.2.0 without regenerating the lock. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
tkgstrator
force-pushed
the
feat/bundle-id-suffix-on-develop
branch
from
August 1, 2026 07:39
eef916f to
e1ebb27
Compare
This was referenced Aug 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--bundle-id-suffix SUFFIXtobuild_patched_ipa.sh, appending.<SUFFIX>to the Info.plistCFBundleIdentifierso a patched IPA installs alongside the original app instead of overwriting it.uv.lockrides along: develop bumpedpyproject.tomlto 0.2.0 in chore: bump version to 0.2.0 #19 without regenerating the lock.Why not just merge
feat/bundle-id-suffix?That branch carries the same feature but forked before #17-#19, so it lacks the
verify_sitesoverload resolution (namespace-qualified labels + parameter-type matching) and thecaves.pyplaceholder-row support. Its consumer — KiouForge, now targeting KIOU 1.1.0 — needs both: without them 5 of 56 sites fail to resolve, and 1.1.0 has a recipe row whose method no longer exists in the build.Rebuilding the flag on top of develop keeps the two lines from drifting further apart.
feat/bundle-id-suffixcan be closed once this lands.Test plan
uv run pytest tests/— 89 passedbash -n tools/build_patched_ipa.shverify_sites— 55/55 (1.1.0) and 56/56 (1.0.2) sites verifiedmake ipa BUNDLE_ID_SUFFIX=chinlan→com.neconome.shogi→com.neconome.shogi.chinlanmake ipawith no suffix → noCFBundleIdentifierrewrite🤖 Generated with Claude Code