ci: remove duplicate psalm workflow - #21
Merged
Merged
Conversation
Two workflow files (.github/workflows/psalm.yml and psalm-matrix.yml)
both declared `name: Static analysis` and shared the same concurrency
group `psalm-${{ github.head_ref || github.run_id }}` with
`cancel-in-progress: true`. Whichever workflow GitHub scheduled second
cancelled the first. When the matrix workflow lost the race, its
summary job (`if: always()`, `exit 1` when not success) saw the
cancellation and produced a red `static-psalm-analysis-summary` check
on every PR, even when psalm itself passed.
Drop psalm.yml and keep psalm-matrix.yml: the matrix variant runs psalm
against every supported nextcloud/ocp version with the matching php-min
and includes the summary aggregate job intended for branch protection.
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/psalm.yml, which duplicatedpsalm-matrix.yml.name: Static analysisand shared the sameconcurrency.groupwithcancel-in-progress: true, so they cancelled each other on every PR.summaryjob (if: always(),exit 1on non-success) sawcancelledand produced a redstatic-psalm-analysis-summarycheck on every PR — even when psalm itself passed. See PR feat(userEventListeners): add UserEventListener and UserStatsJob #17 for an example.nextcloud/ocpversion with the matchingphp-minand includes the aggregatestatic-psalm-analysis-summaryjob intended for branch protection.Test plan
CANCELLED, andstatic-psalm-analysis-summaryis green.as/dev/NSW-876-user-event-listener) and confirmstatic-psalm-analysis-summaryis green there too.mainreferences the failing check by name, confirm the rule still resolves (static-psalm-analysis-summaryis provided by the surviving workflow).