Skip to content

Kh/dev/disable admin theming via fe - #9

Merged
bromiesTM merged 3 commits into
ionos-devfrom
kh/dev/disable-admin-theming-via-FE
Aug 26, 2025
Merged

Kh/dev/disable admin theming via fe#9
bromiesTM merged 3 commits into
ionos-devfrom
kh/dev/disable-admin-theming-via-FE

Conversation

@bromiesTM

Copy link
Copy Markdown

@bromiesTM
bromiesTM requested a review from Copilot August 19, 2025 07:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a feature to disable admin theming via the frontend for Nextcloud Workspace. It introduces a new configuration option that allows administrators to restrict theming customizations while maintaining logo upload functionality and updating default branding to "Nextcloud Workspace".

Key changes include:

  • Added disable_admin_theming configuration option with backend enforcement
  • Updated default branding from "Nextcloud" to "Nextcloud Workspace" with IONOS slogan
  • Modified admin interface to conditionally hide theming controls when disabled

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
lib/private/legacy/OC_Defaults.php Updates default branding strings and adds IONOS slogan
apps/theming/lib/ThemingDefaults.php Adds method to check if admin theming is disabled
apps/theming/lib/Controller/ThemingController.php Implements backend validation to prevent theming updates when disabled
apps/theming/src/AdminTheming.vue Conditionally hides theming controls in frontend based on configuration
apps/theming/lib/Settings/Admin.php Passes admin theming disabled state to frontend
apps/theming/tests/ThemingDefaultsTest.php Adds unit tests for the new admin theming disabled functionality
apps/theming/lib/Command/UpdateConfig.php Adds support for the new configuration key in CLI commands
apps/theming/src/mixins/admin/FieldMixin.js Includes new config field in style refresh logic
apps/theming/lib/Themes/IonosTheme.php Removes logo filter for IONOS theme
IONOS Updates submodule pointer

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread apps/theming/lib/Controller/ThemingController.php Outdated
Comment thread apps/theming/src/AdminTheming.vue
@tanyaka
tanyaka force-pushed the kh/dev/disable-admin-theming-via-FE branch from efc1a52 to 3b36ca0 Compare August 20, 2025 10:54
Comment thread apps/theming/lib/Controller/ThemingController.php Outdated
Comment thread apps/theming/css/ionos/_layout.css

@tanyaka tanyaka left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already noticed, the is a minor visual issue for "undo changes" button for unchanged Name and Slogan input fields in theming settings for admin. The problem: The frontend was comparing current values against hardcoded default values. So let's introduce default to initial state and compare with it, see 44f420a. Also for default URL.

@bromiesTM
bromiesTM force-pushed the kh/dev/disable-admin-theming-via-FE branch 2 times, most recently from b4110c7 to 3f0ddbd Compare August 26, 2025 06:09
bromiesTM and others added 2 commits August 26, 2025 09:55
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
To allow the instance admin to change certain theming values while keeping the IONOS values as fallback

Signed-off-by: Kai Henseler <kai.henseler@strato.de>
@bromiesTM
bromiesTM force-pushed the kh/dev/disable-admin-theming-via-FE branch from 3f0ddbd to d807f86 Compare August 26, 2025 07:55

@tanyaka tanyaka left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review OK.

…n theming)

Signed-off-by: Kai Henseler <kai.henseler@strato.de>
@bromiesTM
bromiesTM force-pushed the kh/dev/disable-admin-theming-via-FE branch from d807f86 to 7d6ea2e Compare August 26, 2025 10:35
@bromiesTM
bromiesTM merged commit d66768d into ionos-dev Aug 26, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants