Kh/dev/disable admin theming via fe - #9
Conversation
bromiesTM
commented
Aug 19, 2025
- chore: move theming config into nextcloud ncw-config#7
- update config submodule pointer
There was a problem hiding this comment.
Pull Request Overview
This PR implements a feature to disable admin theming via the frontend for Nextcloud Workspace. It introduces a new configuration option that allows administrators to restrict theming customizations while maintaining logo upload functionality and updating default branding to "Nextcloud Workspace".
Key changes include:
- Added
disable_admin_themingconfiguration option with backend enforcement - Updated default branding from "Nextcloud" to "Nextcloud Workspace" with IONOS slogan
- Modified admin interface to conditionally hide theming controls when disabled
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/private/legacy/OC_Defaults.php | Updates default branding strings and adds IONOS slogan |
| apps/theming/lib/ThemingDefaults.php | Adds method to check if admin theming is disabled |
| apps/theming/lib/Controller/ThemingController.php | Implements backend validation to prevent theming updates when disabled |
| apps/theming/src/AdminTheming.vue | Conditionally hides theming controls in frontend based on configuration |
| apps/theming/lib/Settings/Admin.php | Passes admin theming disabled state to frontend |
| apps/theming/tests/ThemingDefaultsTest.php | Adds unit tests for the new admin theming disabled functionality |
| apps/theming/lib/Command/UpdateConfig.php | Adds support for the new configuration key in CLI commands |
| apps/theming/src/mixins/admin/FieldMixin.js | Includes new config field in style refresh logic |
| apps/theming/lib/Themes/IonosTheme.php | Removes logo filter for IONOS theme |
| IONOS | Updates submodule pointer |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
efc1a52 to
3b36ca0
Compare
tanyaka
left a comment
There was a problem hiding this comment.
As already noticed, the is a minor visual issue for "undo changes" button for unchanged Name and Slogan input fields in theming settings for admin. The problem: The frontend was comparing current values against hardcoded default values. So let's introduce default to initial state and compare with it, see 44f420a. Also for default URL.
b4110c7 to
3f0ddbd
Compare
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
To allow the instance admin to change certain theming values while keeping the IONOS values as fallback Signed-off-by: Kai Henseler <kai.henseler@strato.de>
3f0ddbd to
d807f86
Compare
…n theming) Signed-off-by: Kai Henseler <kai.henseler@strato.de>
d807f86 to
7d6ea2e
Compare