Skip to content

add richdocuments app - #5

Merged
bromiesTM merged 6 commits into
ionos-devfrom
mk/dev/add_richdocuments_app
Aug 19, 2025
Merged

add richdocuments app#5
bromiesTM merged 6 commits into
ionos-devfrom
mk/dev/add_richdocuments_app

Conversation

@printminion-co

@printminion-co printminion-co commented Aug 11, 2025

Copy link
Copy Markdown

Summary

add richdocuments, viewer app to apps-external

To test locally:

  • start collabora locally collabora/run
  • do check_release.sh pr-5 ncw

TODO

Checklist

@printminion-co printminion-co changed the title Mk/dev/add richdocuments app add richdocuments app Aug 11, 2025
@printminion-co
printminion-co force-pushed the mk/dev/add_richdocuments_app branch 8 times, most recently from 4985bcd to 93db5d4 Compare August 13, 2025 08:04
https://github.com/nextcloud/richdocuments/releases/tag/v8.7.3

git submodule add -f git@github.com:nextcloud/richdocuments.git apps-external/richdocuments
cd apps-external/richdocuments
git checkout v8.7.3

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
@printminion-co
printminion-co force-pushed the mk/dev/add_richdocuments_app branch 6 times, most recently from ac49063 to d4ab909 Compare August 13, 2025 11:58
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
…endencies

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
https://github.com/nextcloud/richdocuments/releases/tag/v8.7.3

git submodule add -f git@github.com:nextcloud/viewer.git apps-external/viewer
cd apps-external/viewer
git checkout v31.0.7

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
@bromiesTM
bromiesTM force-pushed the mk/dev/add_richdocuments_app branch from d4ab909 to 0c33d3b Compare August 19, 2025 07:53
@bromiesTM
bromiesTM requested a review from Copilot August 19, 2025 08:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds external Nextcloud apps (richdocuments and viewer) to the project as Git submodules and updates the CI/CD pipeline to build them automatically. This enables integration with collaborative document editing capabilities through the richdocuments app and file viewing through the viewer app.

  • Adds richdocuments and viewer apps as Git submodules in the apps-external directory
  • Updates GitHub Actions workflow to include a new build pipeline for external apps with matrix strategy
  • Modifies artifact building to include external apps in the final build output

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.gitmodules Adds submodule definitions for richdocuments and viewer apps
apps-external/richdocuments Adds richdocuments submodule pointing to specific commit
apps-external/viewer Adds viewer submodule pointing to specific commit
IONOS Updates IONOS submodule to newer commit
.github/workflows/build-artifact.yml Adds matrix-based build pipeline for external apps with dependency management

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/build-artifact.yml Outdated
Comment thread .github/workflows/build-artifact.yml Outdated
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
@bromiesTM
bromiesTM merged commit 2a30abe into ionos-dev Aug 19, 2025
9 of 11 checks passed
@printminion-co
printminion-co deleted the mk/dev/add_richdocuments_app branch September 29, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants