IONOS(ci): Add Psalm taint analysis for external apps - #321
Open
bromiesTM wants to merge 9 commits into
Open
Conversation
Add automated security scanning (SAST) for apps-external submodules that have psalm.xml. Uses a matrix strategy to run per-app analysis with non-blocking errors for existing findings in upstream apps. Also enable workflow on feature branch and release candidate branches for testing purposes. Signed-off-by: Kai Henseler <kai.henseler@strato.de>
bromiesTM
force-pushed
the
kh/dev/static-analysis
branch
from
August 19, 2026 12:45
ce44030 to
91a988e
Compare
GitHub's SARIF uploader requires endColumn values to be at least 1. This step ensures Psalm's taint analysis results are compatible with the security tab by replacing any invalid values with 1. Signed-off-by: Kai Henseler <kai.henseler@strato.de>
bromiesTM
force-pushed
the
kh/dev/static-analysis
branch
from
August 19, 2026 12:58
348cfe1 to
f555eac
Compare
Without authentication, Composer downloads from api.github.com hit GitHub's unauthenticated rate limit, causing transient HTTP 504 errors across all matrix app jobs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
user_oidc locks psalm/phar 6.13.1 which requires PHP >=8.2, but the workflow runs 8.1. Static analysis does not execute the code, so platform constraints on analysis tooling do not matter at runtime. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- apps/theming/lib/Controller/IconController.php: extend @return type to include 'image/png' — the IONOS fallback path returns a png DataDisplayResponse but the annotation only declared 'image/x-icon', causing MoreSpecificReturnType and InvalidReturnStatement errors. - build/psalm-baseline-security.xml: remove the fixed $appIcon TaintedFile entry from IconBuilder.php; it was resolved upstream and --update-baseline was removing it at runtime, causing git diff --exit-code to fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The codeql-action/upload-sarif step requires this permission to post results to the GitHub Security tab. Without it the upload fails with "Resource not accessible by integration". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Move generate-sast-matrix and static-code-analysis-security-apps out of static-code-analysis.yml into a new standalone ionos-sast-apps.yml. This isolates IONOS-specific logic so the upstream workflow file can be kept unmodified and synced without conflicts.
Drop the IONOS-specific additions that were embedded in this file (now in ionos-sast-apps.yml) and pull in the current upstream content: PHP 8.3, dorny/paths-filter change detection, psalm:strict job, and the summary gate job needed for branch protection rules.
…igger The previous commit over-shot by applying the full current upstream content (PHP 8.3, psalm:strict, changes-filter). The correct baseline for this fork is the ionos-dev sync state (PHP 8.1, action SHAs from the May 2025 sync). The only intentional IONOS delta is adding rc/** to the push trigger so release candidate branches are covered, and the security-events: write permission already landed on ionos-dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.