Tkl/mk/review/kh/dev/spacing and fonts - #10
Merged
Conversation
tanyaka
force-pushed
the
tkl/mk/review/kh/dev/spacing-and-fonts
branch
from
August 20, 2025 08:02
9ca94ec to
51f9c5d
Compare
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de> Co-authored-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de> Co-authored-by: Misha M.-Kupriyanov <kupriyanov@strato.de> Co-authored-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
tanyaka
force-pushed
the
tkl/mk/review/kh/dev/spacing-and-fonts
branch
from
August 20, 2025 08:11
51f9c5d to
001e877
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the IONOS theme implementation by restructuring the custom CSS from a large inline string to separate modular CSS files and improving font management.
Key changes:
- Extracts hardcoded CSS into separate CSS files (variables.css, sidebar.css, files.css, _layout.css)
- Implements dynamic font loading for Open Sans with proper @font-face declarations
- Adds class constants for better maintainability and configuration management
Reviewed Changes
Copilot reviewed 5 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/theming/lib/Themes/IonosTheme.php | Refactored from inline CSS to modular file loading with improved font management and constants |
| apps/theming/css/ionos/variables.css | New CSS variables file defining IONOS-specific color schemes and component styling |
| apps/theming/css/ionos/sidebar.css | New sidebar-specific styling extracted from the main theme class |
| apps/theming/css/ionos/files.css | New file management interface styling with comprehensive component theming |
| apps/theming/css/ionos/_layout.css | New layout styling for header and content structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Closed
Signed-off-by: Kai Henseler <kai.henseler@strato.de> Co-authored-by: Misha M.-Kupriyanov <kupriyanov@strato.de> Co-authored-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
tanyaka
force-pushed
the
tkl/mk/review/kh/dev/spacing-and-fonts
branch
from
August 20, 2025 08:49
001e877 to
1cb3655
Compare
bromiesTM
approved these changes
Aug 20, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist