fix(templates/listItem): escape % in CSS filter values for vsprintf compatibility - #24
Merged
Merged
Conversation
…ompatibility Signed-off-by: Matthias Sauer <sauerm@strato.de>
There was a problem hiding this comment.
Pull request overview
Fixes a printf-formatting incompatibility in the IONOS listItem email template by escaping literal % characters inside inline CSS so the template can be safely formatted without warnings/corrupted output.
Changes:
- Escaped percentage values in
filter:from100%/0%to100%%/0%%for vsprintf/sprintf compatibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The filter CSS property in the IONOS listItem.html template contained unescaped % characters (saturate(100%), invert(0%)).
vsprintf() attempted to interpret %) as a format specifier, causing a PHP warning and potentially corrupting the rendered output.
Escaped both occurrences to %% to match the convention already used throughout the template.
Test ### plan