Fix PR review issues: head.html test content, misleading test name, and missing try/finally - #22
Draft
printminion-co with Copilot wants to merge 3 commits into
Draft
printminion-co with Copilot wants to merge 3 commits into
printminion-co with Copilot wants to merge 3 commits into
Conversation
…olution Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Co-authored-by: printminion-co <145785698+printminion-co@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add brand-aware email templates with asset resolution
Fix PR review issues: head.html test content, misleading test name, and missing try/finally
Mar 10, 2026
bromiesTM
force-pushed
the
kh/dev/brand-aware-templates
branch
from
March 16, 2026 08:22
58d1dd3 to
911878c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three issues flagged in code review on the brand-aware templates PR.
Changes
lib/templates/email/head.html– Replaced committed test fixture string (<div>Test Head Template</div>) with a backward-compatibility comment; brand-specific templates underionos/are the intended path.tests/unit/BrandResolverTest.php– RenamedtestGetBrandReturnsDefaultWhenNotConfigured→testGetBrandReturnsDefaultBrand(the test explicitly passes'ionos', so it validates the default brand value, not an unconfigured state); assertion updated to useBrandResolver::DEFAULT_BRANDinstead of the hardcoded string.tests/lib/EMailTemplateTest.php– Wrapped thefile_put_contentswrite and all assertions intestIncludeTemplateFileIsCoveredwithtry/finallyto guarantee file restoration on assertion failure or exception:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.