Skip to content

fix(templates/listItem): add second template literal - #16

Merged
bromiesTM merged 1 commit into
masterfrom
kh/dev/fix-broken-mails
Dec 4, 2025
Merged

fix(templates/listItem): add second template literal#16
bromiesTM merged 1 commit into
masterfrom
kh/dev/fix-broken-mails

Conversation

@bromiesTM

Copy link
Copy Markdown
Contributor

There are two template literals

  1. Icon
  2. Text

As the second one was missing we had two icons and no text in those list items

@bromiesTM
bromiesTM requested a review from Copilot December 3, 2025 09:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the email list item template where the second template literal placeholder was missing, causing the template to render two icons instead of an icon and text. The fix replaces a hardcoded image tag with a %s placeholder that will be populated with the appropriate content at runtime.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/templates/email/listItem.html
There are two template literals
1. Icon
2. Text

As the second one was missing we had two icons and no text in those list items

Signed-off-by: Kai Henseler <kai.henseler@strato.de>
@bromiesTM
bromiesTM force-pushed the kh/dev/fix-broken-mails branch from 9a51c4b to c404ad1 Compare December 4, 2025 14:29
@bromiesTM
bromiesTM merged commit d3c66eb into master Dec 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants