feat: Add eurooffice app configuration - #169
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical and moderate findings remain in configure.sh.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds Euro-Office to the build and runtime configuration.
Changes:
- Adds
euroofficeto the full-build app list. - Configures the document server URL, JWT secret, and optional storage URL.
File summaries
| File | Summary | Findings |
|---|---|---|
Makefile |
Adds Euro-Office to the full-build apps. | None |
configure.sh |
Adds Euro-Office configuration and updates app orchestration. | Critical (3 votes): Collabora configuration is no longer invoked. Moderate (3 votes): required settings can be missing while Euro-Office remains enabled. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| configure_mail_app | ||
| configure_viewer_app | ||
| configure_collabora_app | ||
| configure_eurooffice_app |
Comment on lines
+496
to
+501
| enable_app eurooffice "Euro-Office" | ||
|
|
||
| if ! validate_env_vars APP_EUROOFFICE_DOCUMENT_SERVER_URL APP_EUROOFFICE_JWT_SECRET; then | ||
| log_warning "eurooffice app configuration skipped due to missing environment variables" | ||
| return 0 | ||
| fi |
2 tasks
bromiesTM
commented
Sep 21, 2026
| configure_eurooffice_app() { | ||
| log_info "Configuring eurooffice app..." | ||
|
|
||
| enable_app eurooffice "Euro-Office" |
Contributor
Author
There was a problem hiding this comment.
We could / should manually disable richdocuments here to make sure customers with enabled collabora dont have both apps enabled?
printminion-co
requested changes
Sep 22, 2026
bromiesTM
added this pull request to stack #171
September 22, 2026 13:13
bromiesTM
force-pushed
the
kh/deb/configure-eurooffice
branch
2 times, most recently
from
September 22, 2026 13:22
d931c2f to
b3e4964
Compare
Add eurooffice to the build apps list and implement its configuration function with support for DocumentServerUrl, jwt_secret, and optional StorageUrl settings. Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Introduce a DOCUMENT_APP env var (default: "eurooffice") that selects which document editor is configured and enabled at runtime. The inactive app is explicitly disabled, allowing both apps to be shipped in the image while the Helm chart decides which one to activate. Valid values: eurooffice | richdocuments Signed-off-by: Kai Henseler <kai.henseler@strato.de> Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
…onfiguration This change ensures that both richdocuments and eurooffice applications are disabled during the configuration process, preventing conflicts and ensuring a smoother setup. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
printminion-co
force-pushed
the
kh/deb/configure-eurooffice
branch
from
September 23, 2026 13:02
b3e4964 to
fcc7d81
Compare
printminion-co
removed this pull request from stack #171
September 23, 2026 13:51
printminion-co
added this pull request to stack #173
September 23, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add eurooffice to the build apps list and implement its configuration function with support for DocumentServerUrl, jwt_secret, and optional StorageUrl settings.