feat(workflow): enhance submodule trigger workflow with PR URL and nu… by Arsalanulhaq · Pull Request #128 · IONOS-Productivity/ncw-config

Arsalanulhaq · 2026-03-10T10:31:51Z

This pull request enhances the .github/workflows/submodule-trigger-workflow.yml workflow to improve traceability and communication between submodule updates and their triggering pull requests. The main improvements are the propagation and display of PR URLs and numbers throughout the workflow, as well as more robust handling of PR creation and output. The most important changes are grouped as follows:

Traceability and Output Enhancements

Added outputs for pr_url and pr_number to the create-submodule-pr job, making these values accessible to downstream jobs and steps.
Modified the milestone retrieval step to also fetch and output the triggering PR's URL and number, increasing visibility of the originating PR.
Updated the PR creation step to consume and propagate these outputs, so the submodule update PR can reference the triggering PR.
Appended a link to the triggering PR in the body of the generated submodule update PR, if available, improving traceability.
Enhanced the logging step to display the submodule update PR URL if it was successfully created, providing clearer feedback in workflow logs.

Robust PR Creation and Data Handling

Improved the logic for detecting existing PRs and creating new ones by handling both the PR URL and number, and ensuring these are output for use in later steps. [1] [2]

Copilot

Pull request overview

Enhances the submodule-trigger workflow to improve traceability by propagating the created submodule-update PR URL/number (and the triggering PR URL/number) through job outputs and logging, and by linking the triggering PR in the generated PR body.

Changes:

Exposes pr_url / pr_number as outputs of the create-submodule-pr job (from the PR creation step).
Extends milestone discovery to also capture the triggering PR URL/number and makes them available to later steps.
Improves PR creation flow to surface both URL and number, and logs the created PR URL in the final summary step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Arsalanulhaq · 2026-03-10T11:09:02Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-03-10T11:09:10Z

@Arsalanulhaq I've opened a new pull request, #129, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-03-10T11:11:13Z

@Arsalanulhaq I've opened a new pull request, #130, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-03-10T11:12:24Z

@Arsalanulhaq I've opened a new pull request, #131, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…mber outputs Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Arsalanulhaq requested a review from Copilot March 10, 2026 10:40

Copilot started reviewing on behalf of Arsalanulhaq March 10, 2026 10:40 View session

Arsalanulhaq added this to the ncw-5 milestone Mar 10, 2026

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Comment thread .github/workflows/submodule-trigger-workflow.yml

Comment thread .github/workflows/submodule-trigger-workflow.yml

Arsalanulhaq force-pushed the fix/add-pr-url-output-to-submodule-trigger branch from af8bc7e to 555bee2 Compare March 10, 2026 10:55

Arsalanulhaq requested a review from Copilot March 10, 2026 10:55

Copilot started reviewing on behalf of Arsalanulhaq March 10, 2026 10:55 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Comment thread .github/workflows/submodule-trigger-workflow.yml Outdated

Copilot AI mentioned this pull request Mar 10, 2026

[WIP] Enhance submodule trigger workflow with PR URL and number #129

Closed

4 tasks

Copilot AI mentioned this pull request Mar 10, 2026

[WIP] Apply feedback from review on submodule trigger workflow enhancement #130

Closed

Copilot AI mentioned this pull request Mar 10, 2026

[WIP] WIP address feedback on enhancing submodule trigger workflow #131

Closed

Arsalanulhaq force-pushed the fix/add-pr-url-output-to-submodule-trigger branch from 555bee2 to 6cd871f Compare March 10, 2026 12:11

Arsalanulhaq requested a review from Copilot March 10, 2026 12:13

Copilot started reviewing on behalf of Arsalanulhaq March 10, 2026 12:13 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Comment thread .github/workflows/submodule-trigger-workflow.yml Outdated

Arsalanulhaq force-pushed the fix/add-pr-url-output-to-submodule-trigger branch from 6cd871f to 9aa62d3 Compare March 10, 2026 14:24

Arsalanulhaq requested a review from Copilot March 10, 2026 14:28

Copilot started reviewing on behalf of Arsalanulhaq March 10, 2026 14:29 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Comment thread .github/workflows/submodule-trigger-workflow.yml Outdated

Arsalanulhaq force-pushed the fix/add-pr-url-output-to-submodule-trigger branch from 9aa62d3 to edd2ea7 Compare March 10, 2026 14:33

Arsalanulhaq requested a review from Copilot March 10, 2026 14:34

Copilot started reviewing on behalf of Arsalanulhaq March 10, 2026 14:34 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Comment thread .github/workflows/submodule-trigger-workflow.yml

Comment thread .github/workflows/submodule-trigger-workflow.yml Outdated

Arsalanulhaq force-pushed the fix/add-pr-url-output-to-submodule-trigger branch from edd2ea7 to c336e76 Compare March 10, 2026 14:43

Arsalanulhaq requested a review from Copilot March 10, 2026 14:45

Copilot started reviewing on behalf of Arsalanulhaq March 10, 2026 14:45 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Comment thread .github/workflows/submodule-trigger-workflow.yml Outdated

Arsalanulhaq force-pushed the fix/add-pr-url-output-to-submodule-trigger branch from c336e76 to 72db76b Compare March 10, 2026 14:50

Arsalanulhaq requested a review from Copilot March 10, 2026 14:51

Copilot started reviewing on behalf of Arsalanulhaq March 10, 2026 14:52 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Comment thread .github/workflows/submodule-trigger-workflow.yml

feat(workflow): enhance submodule trigger workflow with PR URL and nu…

c530802

…mber outputs Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>

Arsalanulhaq force-pushed the fix/add-pr-url-output-to-submodule-trigger branch from 72db76b to c530802 Compare March 10, 2026 14:55

Arsalanulhaq requested a review from Copilot March 10, 2026 14:56

Copilot started reviewing on behalf of Arsalanulhaq March 10, 2026 14:57 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Arsalanulhaq requested a review from Copilot March 10, 2026 16:02

Copilot started reviewing on behalf of Arsalanulhaq March 10, 2026 16:03 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

printminion-co approved these changes Mar 11, 2026

View reviewed changes

Arsalanulhaq merged commit 3f0d06e into main Mar 11, 2026
22 checks passed

Arsalanulhaq deleted the fix/add-pr-url-output-to-submodule-trigger branch March 11, 2026 09:55

printminion-co mentioned this pull request Mar 11, 2026

IONOS(config): update submodule 3f0d06e (feat(workflow): enhance submodule trigger workflow with PR URL and number outputs) IONOS-Productivity/ncw-server#263

Open

Uh oh!

Conversation

Arsalanulhaq commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Arsalanulhaq commented Mar 10, 2026

Uh oh!

Copilot AI commented Mar 10, 2026

Uh oh!

Copilot AI commented Mar 10, 2026

Uh oh!

Copilot AI commented Mar 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Arsalanulhaq commented Mar 10, 2026 •

edited

Loading