chore: bump nextcloud/ocp to dev-stable32 (NSW-946) - #40
Merged
Conversation
The app already declares NC32 support (appinfo/info.xml max-version="32") and CI already Psalms against stable32, because psalm-matrix.yml derives its matrix from info.xml. Only the composer dev-dependency was left on dev-stable31, so a local `composer psalm` run checked against the wrong OCP stubs. Align it with the highest supported NC version. Jira: NSW-946 Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nextcloud/ocpfromdev-stable31todev-stable32incomposer.json+composer.lockNo
appinfo/info.xmlchange: the app already declaresmin-version="31" max-version="32".Why
Part of the NC32 sweep over IONOS-owned apps. This app was already NC32-compatible — CI
Psalms it against stable32 today, because
psalm-matrix.ymlderives its matrix frominfo.xmlvia
nextcloud-version-matrixand then doescomposer require --dev nextcloud/ocp:${{ matrix.ocp-version }}.The
composer.jsonpin only affects local runs, wherecomposer psalmwas checking againstNC31 stubs. This aligns it.
Audit (NC32 removed APIs)
OC_Helper::— none ✅OC_Template/OCP\Template/OC_Util::add*— none ✅appinfo/app.php— absent ✅/apps/files/api/v1/thumbnail— none ✅php: ^8.1andconfig.platform.php: 8.1deliberately unchanged — the app still declaresmin-version="31", and the constraint tracks the lowest supported NC.Jira: NSW-946