feat(AppsMenu): enable click on grid items for better navigation - #36
Merged
Conversation
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
printminion-co
force-pushed
the
mk/dev/enable_click_on_grid_item
branch
from
October 31, 2025 17:26
a72d455 to
947894e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the AppsMenu component to improve HTML semantics by making the anchor (<a>) element the primary container for each app item, rather than wrapping it inside a <div>. This change simplifies the DOM structure and improves accessibility.
Key Changes:
- Restructured HTML to use
<a>as the app item container with<div>wrapping the icon - Adjusted CSS focus outline from 2px to 1px for better visual consistency
- Updated tests to reflect the new DOM structure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/view/AppsMenu.vue | Restructured app item DOM to use anchor element as container, added pointer-events: none to icon wrapper, adjusted focus outline size, and added color: inherit |
| src/tests/AppsMenu.spec.ts | Updated tests to query attributes on .ncwappsmenu__app-item directly instead of nested .ncwappsmenu__app-icon |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.