style(buttons): remove FA-specific chevron icon size workaround - #153
Closed
bromiesTM wants to merge 1 commit into
Closed
style(buttons): remove FA-specific chevron icon size workaround#153bromiesTM wants to merge 1 commit into
bromiesTM wants to merge 1 commit into
Conversation
The .vs__open-indicator-button svg size override was added to compensate for Font Awesome chevron icons rendering smaller than MDI equivalents. Now using upstream MDI icons directly, the workaround is no longer needed.
5 tasks
Contributor
|
Sorry for late feedback. We should revert all the changes related FA, please consider the last 7 commits of https://github.com/IONOS-Productivity/nc-theming/commits/main/: 2c9bea3 till a06a89f, additionally fixing the app info version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .vs__open-indicator-button svg size override was added to compensate for Font Awesome chevron icons rendering smaller than MDI equivalents. Now using upstream MDI icons directly, the workaround is no longer needed.