style(buttons): remove FA-specific chevron icon size workaround - #145
Conversation
The .vs__open-indicator-button svg size override was added to compensate for Font Awesome chevron icons rendering smaller than MDI equivalents. Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
There was a problem hiding this comment.
Pull request overview
This PR removes a CSS size override that targeted a Vue Select open-indicator chevron SVG (.vs__open-indicator-button svg), which was previously used as a Font Awesome-specific workaround and is no longer needed.
Changes:
- Removed the
.vs__open-indicator-button svg { height/width: 24px; }workaround from the buttons stylesheet.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…utton" This reverts commit 5a60a29. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
This reverts commit 88860e1. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
… down icon size for FA icons" This reverts commit b7c4b80. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
This reverts commit 9c1cc6c. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
…own icon size for FA icons" This reverts commit 8843e2b. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
|
Pushed 5 revert commits on top of this PR for review (please drop / squash / amend as appropriate):
Net effect on top of your existing change:
Conflicts during revert (resolved here, please double-check):
Borderline — not reverted, please decide: Visual checks before merge: file navigator sidebar icons, sub-navigation toggle, breadcrumb separator, sort/breadcrumb dropdown chevron. |
printminion-co
left a comment
There was a problem hiding this comment.
please read commits and comment
Summary
.vs__open-indicator-button svgsize override that was added to compensate for Font Awesome chevron icons rendering smaller than MDI equivalents