Skip to content

style(buttons): remove FA-specific chevron icon size workaround - #145

Merged
tanyaka merged 6 commits into
mainfrom
tkl/dev/remove-chevron-FA-workaround-V32
May 7, 2026
Merged

style(buttons): remove FA-specific chevron icon size workaround#145
tanyaka merged 6 commits into
mainfrom
tkl/dev/remove-chevron-FA-workaround-V32

Conversation

@tanyaka

@tanyaka tanyaka commented May 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Removes the .vs__open-indicator-button svg size override that was added to compensate for Font Awesome chevron icons rendering smaller than MDI equivalents
  • This workaround is no longer needed since MDI icons are now used

The .vs__open-indicator-button svg size override was added
to compensate for Font Awesome chevron icons rendering
smaller than MDI equivalents.

Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a CSS size override that targeted a Vue Select open-indicator chevron SVG (.vs__open-indicator-button svg), which was previously used as a Font Awesome-specific workaround and is no longer needed.

Changes:

  • Removed the .vs__open-indicator-button svg { height/width: 24px; } workaround from the buttons stylesheet.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…utton"

This reverts commit 5a60a29.

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
This reverts commit 88860e1.

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
… down icon size for FA icons"

This reverts commit b7c4b80.

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
This reverts commit 9c1cc6c.

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
…own icon size for FA icons"

This reverts commit 8843e2b.

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
@printminion-co

Copy link
Copy Markdown
Contributor

Pushed 5 revert commits on top of this PR for review (please drop / squash / amend as appropriate):

  • 32de3f3 revert 5a60a29 — sub-navigation toggle icon size (was the unfinished half of b7c4b80's FA story; "v30.0.5 update" is moot at v33)
  • 624ffa2 revert 88860e1 — breadcrumb icon separator size (also originally framed as v30.0.5)
  • c7b0686 revert b7c4b80 — explicit FA chevron / sub-nav size bump
  • fe5adce revert 9c1cc6c — explicit FA navigation-entry icon size
  • eba8783 revert 8843e2b — explicit FA chevron + sub-nav height

Net effect on top of your existing change:

  • css/files.css.vue-crumb__separator loses width:16px; height:16px;, keeps color
  • css/navigation.css — both span[role=img]>svg rules (inside .app-navigation-entry and .button-vue--icon-only:not(.app-navigation-toggle)) lose their pixel sizes, keep color
  • css/buttons.css — unchanged (your PR already deletes the chevron block)

Conflicts during revert (resolved here, please double-check):

  • b7c4b80 / 8843e2b buttons.css portions → block already removed by your PR, accepted the deletion
  • b7c4b80 navigation.css → kept color token at the current var(--ion-button-sidebar-text) (not the older --ion-color-secondary)
  • 9c1cc6c navigation.css → kept the color line that the darkmode commit (ca6e63c) added later, dropped only the size lines

Borderline — not reverted, please decide: c96e222 styles(files): fix grid folder-icon icon size due to v30.0.7 update. Its diff is mixed (selector specificity tightening plus min-height 60→80%) — the selector change looks like a real v33-DOM fix, not an FA workaround, so I left it alone.

Visual checks before merge: file navigator sidebar icons, sub-navigation toggle, breadcrumb separator, sort/breadcrumb dropdown chevron.

@printminion-co printminion-co left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please read commits and comment

@tanyaka
tanyaka merged commit de7a242 into main May 7, 2026
18 checks passed
@printminion-co
printminion-co deleted the tkl/dev/remove-chevron-FA-workaround-V32 branch May 7, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants