feat(header): allow the product name to be configured - #33
Open
printminion-co with Copilot wants to merge 1 commit into
Open
feat(header): allow the product name to be configured#33printminion-co with Copilot wants to merge 1 commit into
printminion-co with Copilot wants to merge 1 commit into
Conversation
The product name in the global header is currently a hardcoded SVG with the letters as vector paths, so a Nextcloud instance cannot name itself without forking this app or reaching into its DOM from outside. This adds an optional `productName` prop to HeaderLogo, provided through the existing `IInitialState` pipeline from a new `ionos_product_name` system config key — the same pattern already used for `ionos_homepage`, `ionos_help_target_link` and `ionos_peer_products`. Fully backwards compatible: when the key is unset or empty the wordmark SVG renders exactly as before, so existing deployments see no change. Verified: `npm run build` succeeds, `npm run lint` is clean, and `npm run stylelint` reports the same 3 pre-existing warnings as on the base branch (UserMenu.vue:190, styles.scss:30/32) with none added. Co-authored-by: printminion-co <145785698+printminion-co@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
printminion-co
August 13, 2026 07:45
View session
printminion-co
marked this pull request as ready for review
August 13, 2026 15:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #32 onto
ionos-dev-v33. The global header's wordmark is a hardcoded SVG, making it impossible to rename the product for a deployment without forking or DOM injection.Changes
lib/Listener/BeforeTemplateRenderedListener.php— readsionos_product_namefrom system config and injects it intoIInitialStatesrc/components/HeaderLogo.vue— adds optionalproductNameprop; renders a text node when set, falls back to the existing SVG wordmark when empty/unsetsrc/main.ts— wiresproductNamefrom initial state intoHeaderLogoFully backwards compatible — unset or empty
ionos_product_nameleaves the header unchanged.