IONOS(ci): trigger artifactory/ghcr.io/remote-trigger jobs on per-major dev/stable branches - #323
Merged
printminion-co merged 1 commit intoAug 24, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the hidrive-next-build GitHub Actions workflow so downstream artifact publishing and remote-trigger jobs correctly run on per-major ionos-dev-v* / ionos-stable-v* branches, aligning job-level if: conditions and diagnostics with the workflow’s on.push.branches triggers.
Changes:
- Extend job-level
if:conditions for Artifactory and GHCR artifact publishing to also matchionos-dev-*/ionos-stable-*branch names (coveringionos-*-v*lanes). - Add a version/RC whitelist gate for the remote QA deployment trigger (via
REMOTE_TRIGGER_NC_VERSION/REMOTE_TRIGGER_RC_BRANCH), while keepingionos-dev/ionos-stableexempt. - Update the “Check configuration” diagnostics and shell branch mappings to reflect the expanded branch patterns and stable glob matching.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
3 tasks
…or dev/stable branches The 'upload-to-artifactory', 'hidirve-next-artifact-to-ghcr_io', and 'trigger-remote-dev-workflow' jobs were being silently skipped on ionos-dev-v32/ionos-stable-v32 pushes: on.push.branches already covers these branches (HDNEXT-2144), so the build itself runs, but the downstream jobs' if: conditions were never updated to match — they only checked for the bare 'ionos-dev'/'ionos-stable' names, 'rc/*', and '*/dev/*'. Port the mature whitelist-gate pattern from ionos-dev-v31: broad startsWith branch matching for the artifact jobs, plus an opt-in REMOTE_TRIGGER_NC_VERSION/REMOTE_TRIGGER_RC_BRANCH gate on the GitLab-trigger job so QA deployment can later be restricted to one NC major/RC at a time (both variables are currently unset repo-wide, so this gate is a no-op today). Scope the NC-version suffix check to ionos-dev-v*/ionos-stable-v* branches only: it was otherwise evaluated for any branch reaching that point, including rc/*, so an rc/* branch whose name happened to end with the whitelisted NC version string would incorrectly pass the gate and bypass the intended exact REMOTE_TRIGGER_RC_BRANCH whitelist match. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
printminion-co
force-pushed
the
agents/trigger-artifactory-push-workflow-v32
branch
from
August 24, 2026 14:43
d4c12c3 to
364de52
Compare
printminion-co
deleted the
agents/trigger-artifactory-push-workflow-v32
branch
August 24, 2026 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ionos-dev-v32's independent copy of the workflow file (confirmed byte-identical toionos-dev-v33's pre-fix copy; this commit is a clean cherry-pick of 11f48fa).ionos-dev-v32(and allionos-dev-v*/ionos-stable-v*per-major branches) already trigger the workflow viaon.push.branches, but three downstream job-levelif:conditions still only matched the bareionos-dev/ionos-stablenames — soupload-to-artifactory,hidirve-next-artifact-to-ghcr_io, andtrigger-remote-dev-workflowwere silently skipped.ionos-dev-v30/ionos-dev-v31(lost whenv32/v33were rewritten with the matrix-cache pipeline), adapted to this file's generic glob style:startsWith(ref_name, 'ionos-dev-'/'ionos-stable-').ARTIFACTORY_STAGE_PREFIX/BUILD_TYPEshell mappings now glob-matchionos-stable*instead of the exact string.trigger-remote-dev-workflownow also matchesionos-dev-v*/ionos-stable-v*, gated by an opt-inREMOTE_TRIGGER_NC_VERSION/REMOTE_TRIGGER_RC_BRANCHwhitelist (mirroring v31) so QA deployment can later be restricted to one NC major/RC at a time. Both vars are currently unset repo-wide, so this gate is a no-op today. Bareionos-dev/ionos-stableare always exempt.ionos-dev,ionos-stable,ionos-dev-v30,ionos-dev-v31behavior.Test plan
python3 -c "import yaml; yaml.safe_load(...)".ionos-dev-v32and confirmPush to artifactory,Push artifact to ghcr.io, andTrigger remote workflowall run (or skip only for pre-existing reasons, never a branch-name mismatch).ionos-dev/ionos-stable/rc/*/*/dev/*behavior is unchanged.