Skip to content

feat(settings): implement IDelegatedSettings for password policy settings - #3

Open
printminion-co wants to merge 1 commit into
masterfrom
feat/password_policy-delegate-settings
Open

feat(settings): implement IDelegatedSettings for password policy settings#3
printminion-co wants to merge 1 commit into
masterfrom
feat/password_policy-delegate-settings

Conversation

@printminion-co

Copy link
Copy Markdown

Summary

Vanilla-clean extraction of the IONOS delegation patch carried in PR #2 (IONOS(admin-delegation): implement IDelegatedSettings for password policy, cherry-picked from b2ba6de), prepared per upstream-to-vanilla-app.md for contribution to nextcloud/password_policy.

OCA\Password_Policy\Settings\Settings changes from implements ISettings to implements IDelegatedSettings, adding getName() and getAuthorizedAppConfig() plus the IL10N constructor parameter they need. This is app-side only — no ncw-config ADMIN_DELEGATION_MAP registration is included, so it stands on its own upstream.

Why

Every NC major re-applies this same one-file patch onto the fork (v31, now v32 in PR #2, v33 next). Upstreaming it retires that delta permanently. Sibling of the already-open nextcloud/bruteforcesettings#1246.

Preparation notes

  • Branched directly off nextcloud/password_policy:master; this fork's master mirror is currently identical to it, so the diff is exactly the one commit.
  • Commit message reworded to Conventional Commits. No IONOS(...) prefix, no NSW/HDNEXT token, no fork-internal PR or SHA reference.
  • Original author and Signed-off-by: Kai Henseler preserved; no sign-off added.
  • #[\Override] added to the two new methods — the source commit predates them, but upstream's Settings.php marks getForm/getSection/getPriority with it, as does #1246.
  • IL10N is autowired; no DI registration change is needed.

Verification

Run in the shared dev container (.dev/container/dev) from the ncw-server checkout:

  • composer lint — clean
  • composer cs:check — clean, 0 of 41 files need fixing
  • composer psalmcould not run: the app's pinned Psalm requires PHP >= 8.3.16; the container has PHP 8.3.6. Pre-existing environment gap, identical for nc-activity, unrelated to this change. The known pre-existing DocblockTypeContradiction at lib/Validator/HIBPValidator.php:54 (reproduces on bare upstream) is still expected once Psalm can run, and is not addressed here.
  • composer test:unitcould not run: the app's PHPUnit bootstrap requires an installed Nextcloud and the dev container instance is not installed. No test touches the settings class.

Related

…ings

Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants