Skip to content

chore: remove legacy theming header in favour of simplenavigation - #67

Merged
bromiesTM merged 2 commits into
mainfrom
kh/dev/add-simplenavigation-v33
Aug 17, 2026
Merged

chore: remove legacy theming header in favour of simplenavigation#67
bromiesTM merged 2 commits into
mainfrom
kh/dev/add-simplenavigation-v33

Conversation

@bromiesTM

Copy link
Copy Markdown
Collaborator

Update *.layout.php files with nextcloud core v33 versions

Update *.layout.php files with nextcloud core v33 versions

Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy IONOS Svelte-based “global navigation” header implementation and updates the theme’s Nextcloud layout templates to match Nextcloud core v33 structure (including the simplified navigation/header layout).

Changes:

  • Removed the IONOS/ Svelte custom-element project (build config, sources, styles, and dev tooling).
  • Updated core layout templates (layout.user.php, layout.public.php, layout.guest.php) to use the v33 header structure (#header with header-start / header-end containers).
  • Removed the IONOS header linting / dependency review GitHub Actions workflows and adjusted theme CSS accordingly.

Reviewed changes

Copilot reviewed 26 out of 28 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
IONOS/vite.config.ts Removed Vite build configuration for the legacy global navigation element.
IONOS/tsconfig.node.json Removed TS config used for the Vite/Svelte build.
IONOS/tsconfig.json Removed TS config for the Svelte project.
IONOS/svelte.config.js Removed Svelte build configuration.
IONOS/src/vite-env.d.ts Removed Vite/Svelte type references.
IONOS/src/style.scss Removed legacy CSS variables/styles for the custom header components.
IONOS/src/main.ts Removed legacy custom element entrypoint/registrations.
IONOS/src/Header.svelte Removed the legacy ionos-global-nav custom element.
IONOS/src/components/userMenu/UserMenuItem.svelte Removed legacy user-menu item custom element.
IONOS/src/components/userMenu/UserMenu.svelte Removed legacy user-menu custom element.
IONOS/src/components/Icon.svelte Removed legacy SVG icon custom element.
IONOS/README.md Removed documentation for the legacy global navigation project.
IONOS/package.json Removed Node/Svelte devDependencies and scripts for the legacy project.
IONOS/package-lock.json Removed lockfile for the deleted legacy Node project.
IONOS/Makefile Removed Podman-based dev/build helper targets for the legacy project.
IONOS/index.html Removed legacy dev preview page.
IONOS/eslint.config.js Removed ESLint config for the legacy project.
IONOS/Containerfile Removed container image definition for legacy Node dev environment.
IONOS/.vscode/extensions.json Removed VS Code recommendations tied to the legacy Svelte project.
IONOS/.prettierrc Removed Prettier config for the legacy Svelte project.
IONOS/.gitignore Removed legacy Node project ignore rules.
defaults.php Removed script injection for the legacy global navigation bundle.
core/templates/layout.user.php Updated authenticated user layout to Nextcloud v33 header structure.
core/templates/layout.public.php Updated public layout header and footer structure to match v33.
core/templates/layout.guest.php Updated guest layout markup/classes to align with v33 guest header/content.
core/css/server.css Adjusted layout offset CSS after removing the legacy header integration.
.github/workflows/header-linting.yml Removed CI workflow that linted/formatted the legacy IONOS header project.
.github/workflows/dependency-review.yml Removed dependency review workflow.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread core/css/server.css
Comment thread core/templates/layout.user.php

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 28 changed files in this pull request and generated no new comments.

Suppressed comments (4)

core/templates/layout.user.php:19

  • PHP syntax error: the anonymous function assigned to $getUserAvatar is missing a terminating semicolon. As written, this will cause a parse error before any HTML is rendered.
}

core/css/server.css:55

  • CSS targets #content-vue, but the updated templates render the main container as #content. As a result, this margin-top no longer applies and can cause the header/content to overlap depending on positioning. Target the actual #content element (or remove this rule if no longer needed).
div#content-vue  {
	margin-top: 64px !important;
}

core/templates/layout.user.php:69

  • The aria-label currently interpolates $_['logoUrl'] when it is set, which will typically be a URL and is not a meaningful label for screen readers. Use the app/site name consistently instead of a URL.
					aria-label="<?php p($l->t('Go to %s', [$_['logoUrl'] ?: $_['defaultAppName']])); ?>"

core/templates/layout.public.php:55

  • The aria-label uses $_['logoUrl'] as the label text, which will typically be a URL and is not helpful for screen readers. Use a human-readable name (e.g., the theme name) instead.
					   aria-label="<?php p($l->t('Go to %s', [$_['logoUrl']])); ?>">

Comment thread IONOS/src/style.scss
@bromiesTM
bromiesTM merged commit b568388 into main Aug 17, 2026
2 checks passed
@bromiesTM
bromiesTM deleted the kh/dev/add-simplenavigation-v33 branch August 17, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants