chore: remove legacy theming header in favour of simplenavigation - #67
Merged
Conversation
Update *.layout.php files with nextcloud core v33 versions Signed-off-by: Kai Henseler <kai.henseler@strato.de>
4 tasks
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy IONOS Svelte-based “global navigation” header implementation and updates the theme’s Nextcloud layout templates to match Nextcloud core v33 structure (including the simplified navigation/header layout).
Changes:
- Removed the
IONOS/Svelte custom-element project (build config, sources, styles, and dev tooling). - Updated core layout templates (
layout.user.php,layout.public.php,layout.guest.php) to use the v33 header structure (#headerwithheader-start/header-endcontainers). - Removed the IONOS header linting / dependency review GitHub Actions workflows and adjusted theme CSS accordingly.
Reviewed changes
Copilot reviewed 26 out of 28 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| IONOS/vite.config.ts | Removed Vite build configuration for the legacy global navigation element. |
| IONOS/tsconfig.node.json | Removed TS config used for the Vite/Svelte build. |
| IONOS/tsconfig.json | Removed TS config for the Svelte project. |
| IONOS/svelte.config.js | Removed Svelte build configuration. |
| IONOS/src/vite-env.d.ts | Removed Vite/Svelte type references. |
| IONOS/src/style.scss | Removed legacy CSS variables/styles for the custom header components. |
| IONOS/src/main.ts | Removed legacy custom element entrypoint/registrations. |
| IONOS/src/Header.svelte | Removed the legacy ionos-global-nav custom element. |
| IONOS/src/components/userMenu/UserMenuItem.svelte | Removed legacy user-menu item custom element. |
| IONOS/src/components/userMenu/UserMenu.svelte | Removed legacy user-menu custom element. |
| IONOS/src/components/Icon.svelte | Removed legacy SVG icon custom element. |
| IONOS/README.md | Removed documentation for the legacy global navigation project. |
| IONOS/package.json | Removed Node/Svelte devDependencies and scripts for the legacy project. |
| IONOS/package-lock.json | Removed lockfile for the deleted legacy Node project. |
| IONOS/Makefile | Removed Podman-based dev/build helper targets for the legacy project. |
| IONOS/index.html | Removed legacy dev preview page. |
| IONOS/eslint.config.js | Removed ESLint config for the legacy project. |
| IONOS/Containerfile | Removed container image definition for legacy Node dev environment. |
| IONOS/.vscode/extensions.json | Removed VS Code recommendations tied to the legacy Svelte project. |
| IONOS/.prettierrc | Removed Prettier config for the legacy Svelte project. |
| IONOS/.gitignore | Removed legacy Node project ignore rules. |
| defaults.php | Removed script injection for the legacy global navigation bundle. |
| core/templates/layout.user.php | Updated authenticated user layout to Nextcloud v33 header structure. |
| core/templates/layout.public.php | Updated public layout header and footer structure to match v33. |
| core/templates/layout.guest.php | Updated guest layout markup/classes to align with v33 guest header/content. |
| core/css/server.css | Adjusted layout offset CSS after removing the legacy header integration. |
| .github/workflows/header-linting.yml | Removed CI workflow that linted/formatted the legacy IONOS header project. |
| .github/workflows/dependency-review.yml | Removed dependency review workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 28 changed files in this pull request and generated no new comments.
Suppressed comments (4)
core/templates/layout.user.php:19
- PHP syntax error: the anonymous function assigned to $getUserAvatar is missing a terminating semicolon. As written, this will cause a parse error before any HTML is rendered.
}
core/css/server.css:55
- CSS targets
#content-vue, but the updated templates render the main container as#content. As a result, this margin-top no longer applies and can cause the header/content to overlap depending on positioning. Target the actual#contentelement (or remove this rule if no longer needed).
div#content-vue {
margin-top: 64px !important;
}
core/templates/layout.user.php:69
- The aria-label currently interpolates $_['logoUrl'] when it is set, which will typically be a URL and is not a meaningful label for screen readers. Use the app/site name consistently instead of a URL.
aria-label="<?php p($l->t('Go to %s', [$_['logoUrl'] ?: $_['defaultAppName']])); ?>"
core/templates/layout.public.php:55
- The aria-label uses $_['logoUrl'] as the label text, which will typically be a URL and is not helpful for screen readers. Use a human-readable name (e.g., the theme name) instead.
aria-label="<?php p($l->t('Go to %s', [$_['logoUrl']])); ?>">
printminion-co
requested changes
Aug 13, 2026
printminion-co
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update *.layout.php files with nextcloud core v33 versions