Create function to validate input data in the optimize.py script#30
Open
Max4375 wants to merge 13 commits into
Open
Create function to validate input data in the optimize.py script#30Max4375 wants to merge 13 commits into
Max4375 wants to merge 13 commits into
Conversation
…nge github workflow from Black and Flake8 to Ruff
Collaborator
|
Thank you for the input validation function. Is is working and I like how it checks whether profiles actually exists and prints useful error messages. Here are some points I see that could be improved:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.