Skip to content

OIA-241: pin httpx2 + authlib for imio.omnia.core OAuth2 support - #16

Open
duchenean wants to merge 1 commit into
masterfrom
OIA-241-oauth2-sso-apps
Open

OIA-241: pin httpx2 + authlib for imio.omnia.core OAuth2 support#16
duchenean wants to merge 1 commit into
masterfrom
OIA-241-oauth2-sso-apps

Conversation

@duchenean

@duchenean duchenean commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Companion to IMIO/imio.omnia.core#2 (OIA-241).

versions.cfg only:

  • Add httpx2 = 2.7.0, authlib = 1.7.2, httpcore2 = 2.7.0.
  • Override idna = 3.18 (httpx2 needs >=3.18, above the Plone 6.1 KGS pin of 3.11).
  • Keep httpx = 0.28.1 for now with a TODO — droppable once the imio.omnia.assistant release without its unused httpx dependency is pinned here (DELIBE-322 tracks the wider sweep).

Summary by CodeRabbit

  • Chores
    • Updated dependency documentation with clearer “required by” relationships for HTTP/authentication components.
    • Pinned the idna version more explicitly to match the related HTTP constraint.
    • Added a TODO note indicating the httpx pin can be removed in a future release when it’s no longer needed.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The head commit changed during the review from 475b167 to 78335a8.

📝 Walkthrough

Walkthrough

versions.cfg now documents HTTP-related dependency relationships, adds pins for httpx2, authlib, httpcore2, and idna, and annotates the existing httpx pin with a future removal TODO.

Changes

Dependency version documentation

Layer / File(s) Summary
Document HTTP dependency pins
versions.cfg
Adds the OIA-241 TODO and documents pinned versions for httpx2, authlib, httpcore2, and idna, including the idna = 3.18 constraint.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: adding dependency pins for OAuth2 support in imio.omnia.core.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch OIA-241-oauth2-sso-apps

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Biome (2.5.5)
pyrightconfig.json

File contains syntax errors that prevent linting: Line 23: Expected an array, an object, or a literal but instead found ']'.; Line 33: Expected an array, an object, or a literal but instead found ']'.; Line 34: Expected a property but instead found '}'.


Comment @coderabbitai help to get the list of available commands.

@duchenean
duchenean force-pushed the OIA-241-oauth2-sso-apps branch 2 times, most recently from 475b167 to 78335a8 Compare July 29, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant