comments from Paul - #161
Conversation
| "IETF OPSAWG (Operations and Management Area Working Group)"; | ||
| contact | ||
| "WG Web: <https://datatracker.ietf.org/wg/opsawg/> | ||
| "WG Web: https://datatracker.ietf.org/wg/opsawg/ |
| description | ||
| "Indicates support of matching on endpoint groups."; | ||
| } | ||
There was a problem hiding this comment.
I expecte this to be fixed in the edited version by the RFC Editor, but OK
There was a problem hiding this comment.
Welcome back;-)
I aslo expect the editorial nits would be fixed by RFC editor, but since Paul has already point them out, we can maintain it here in case the editor fails to recognize them.
There was a problem hiding this comment.
Authors should not defer work to the RFC Editor as the editor does not know the author's intentions and they may overlook or miss issues.
| } | ||
| description | ||
| "Specifies the endpoint group type."; | ||
| "Specifies the type of the endpoint group (e.g., user, |
| associated with the packet's source and/or destination | ||
| endpoint. | ||
|
|
||
| Note this container is only valid when the ACL type is |
There was a problem hiding this comment.
OK althought part of the description is redundant with teh when clause
There was a problem hiding this comment.
Yes, the intention is to call out the implication that server needs to implement both features to ensure this container is valid.
| <note title="Discussion Venues" removeInRFC="true"> | ||
| <t>Discussion of this document takes place on the | ||
| Operations and Management Area Working Group Working Group mailing list (opsawg@ietf.org), | ||
| Operations and Management Area Working Group mailing list (opsawg@ietf.org), |
There was a problem hiding this comment.
this note will be removed from the final RFC anyway.
|
|
||
| device group: | ||
| : A collection of enterprise devices that share a common access control policies. Refer to {{sec-dg}} for more details. | ||
| Device group: |
There was a problem hiding this comment.
OK. I expect this to be fixed in the edited version bu the RFC Editor.
| : Either the AAA server or the NAS notifies an SDN controller | ||
| of the mapping between the user group ID and related common packet | ||
| header attributes (e.g., the 5-tuple). The exact details of how such notification is performed are out scope of this specification. | ||
| header attributes (e.g., the 5-tuple). The exact details of how such notification is performed are out of scope for this specification. |
There was a problem hiding this comment.
Will leave this one to the RFC Editor.
| this attribute, including the Type, Length, Extended-Type, and the | ||
| "Value". | ||
| : The Length MUST be at most 67 octets. The maximum length is 67 octets to accommodate the maximum group ID of 64 octets plus one octet for Type, one octet for Length, and one octet for Extended-Length. | ||
| : The Length MUST be at most 67 octets. The maximum length is 67 octets to accommodate the maximum group ID of 64 octets plus one octet for Type, one octet for Length, and one octet for Extended-Type. |
|
|
||
| * /acl:acls/acl:acl/acl:aces/acl:ace/ucl:effective-schedule: | ||
| : It specifies the secheduling of ACLs. Unauthorized write access to this data node may allow intruders to | ||
| : It specifies the scheduling of ACLs. Unauthorized write access to this data node may allow intruders to |
| --- back | ||
|
|
||
| # Examples Usage | ||
| # Usage Examples |
There was a problem hiding this comment.
nit: there is trailing space after "group".
| "Adds new match types."; | ||
| "Adds new match criteria based on the group identity | ||
| associated with the packet's source and/or destination | ||
| endpoint. |
There was a problem hiding this comment.
nit: there is trailing space after "endpoint."
There was a problem hiding this comment.
Fixed in 8462028. Thanks for catching them.
No description provided.