Connect and disconnect social accounts in account settings#78
Merged
Conversation
- Additional social identity connection sets an item in session storage - The page detects it then decides whether to log in or connect
useAuth.refresh now returns the new access token. SocialCallbackPage's connect path refreshes first and sends the connect request via raw fetch with that fresh token, so a token that expired during the provider consent screen no longer fails the connect. Using fetch instead of useAxios also avoids the 401 interceptor retrying genuine OAuth errors (which the backend returns as 401) after the code/state have already been consumed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backend
Features
EmailNotVerifiedException+SocialAuthControllerhandler return400with a clear message when the provider email is unverified.GoogleOidcProviderClientnow rejects unverified emails viaEmailNotVerifiedException.KakaoOidcProviderClientverifiesis_email_verified/is_email_validagainst Kakao's classic user API (Kakao's OIDC ID token omits the claim); aRestClientExceptionfrom that call is mapped to an OAuth error rather than surfacing as a 500.application.yaml: override Kakaouser-info-urito the classic user API that exposes the verification flags.Frontend
Features
AccountPage: new "외부 계정 연결" section to connect/disconnect each provider.SocialCallbackPage: detects connect-vs-login intent viasessionStorage, refreshes the access token before connecting (so a token that expired on the consent screen no longer fails the link), and connects through the authenticated endpoint.socialAuthErrors: Korean translations for the connect/disconnect and email-not-verified errors.Refactor
useAuth.refresh()now returns the new access token.resolveResponseErrorto dedupe social-auth error-body parsing.Chore
NaverIcontoNaverIconWhite.