Add account page with name edit and password management#76
Merged
Conversation
- Remove redundant SocialAuthController::getConnectedIdentities
- Extract isNotCurrentUserId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/accountpage: displays name (inline edit) and email; links to password change for password-based accounts/account/change-passwordpage: form to change current passwordGET /users/{id}endpoint returns full account profile (AccountDto) including linked identitiesBackend
Features
GET /api/users/{id}— returnsAccountDto { user: UserDto, identities: UserIdentityDto[] }PATCH /api/users/{id}/password— changes password; throwsNoPasswordException(400) for social-only accounts,WrongPasswordException(406) for wrong current passwordUserDtoexpanded:id,name,email,hasPassword,createdAtAccountDtoaggregatesUserDto+List<UserIdentityDto>Refactor
UserController.isNotCurrentUserIdhelper centralises the ownership guard (was copy-pasted in each handler)ConnectedIdentityResponserenamed toUserIdentityDto;SocialAuthController.getConnectedIdentitiesremoved (now served viaGET /users/{id})DuplicateUserExceptionrenamed toDuplicateEmailExceptionUserMapper.toDtoderiveshasPasswordfromuser.getPassword() != nullFrontend
Features
AccountPage.tsx— shows name (inline edit) and email fromGET /users/{id}; links to/account/change-passwordfor password accounts onlyChangePasswordPage.tsx— form with current/new/confirm password fields; redirects back to/accounton success; guards: JS validation for empty current password, backend@NotBlankenforcementNavBar.tsx— replaced settings gear with user-name dropdown; "Tichu Sim" home link navigates to current room (/rooms/:roomId) or/depending on routetypes.ts— addedUserDto,AccountDto,UserIdentityDto,OidcProviderName