feat(vllm-performance): Added logic for K8s environments garbage collection - #1299
Open
christian-pinto wants to merge 2 commits into
Open
feat(vllm-performance): Added logic for K8s environments garbage collection#1299christian-pinto wants to merge 2 commits into
christian-pinto wants to merge 2 commits into
Conversation
AlessandroPomponio
requested changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds idle-environment garbage collection (GC) to the
vllm_performanceactuator. Previously, Kubernetes deployments released by an experiment were kept alive indefinitely until they were needed again or cleaned up manually. This PR introduces a configurable TTL-based free pool and a background GC loop that automatically deletes stale deployments, with an optional force-delete escalation path for stuck environments.High-Level Changes
free_environment_ttl(default 300 s) controls how long an idle deployment may live before GC deletes it. Setting TTL to0disables the pool and deletes immediately on release.gc_force_delete,gc_force_delete_threshold) allow automatic force-deletion (clearing finalizers, grace_period=0) of deployments that remain stuck in Kubernetes after repeated GC checks.ComponentsManagergains aforce_delete_environmentmethod that deletes the service, clears pod finalizers, and force-deletes pods and the deployment.free_environment_ttl,gc_force_delete, andgc_force_delete_thresholdadded toVLLMPerformanceTestParameterswith validation.Impact
1.10.3 → 1.10.4(patch release).This PR fixes #273