Skip to content

refactor(core): deprecate old fetch entities methods in favour of get_entities - #1271

Merged
AlessandroPomponio merged 3 commits into
mainfrom
ap_1270_deprecate_old_fetch_entities_methods
Jul 28, 2026
Merged

refactor(core): deprecate old fetch entities methods in favour of get_entities#1271
AlessandroPomponio merged 3 commits into
mainfrom
ap_1270_deprecate_old_fetch_entities_methods

Conversation

@AlessandroPomponio

@AlessandroPomponio AlessandroPomponio commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR simplifies sample store entity retrieval by consolidating callers onto the newer get_entities() API, deprecating older fetch helpers, and updating affected tests and internal usages accordingly.

High-level Changes

  • Replaced internal and caller usage of legacy entity fetch methods such as entityWithIdentifier() and entities_with_identifiers() with get_entities().
  • Removed duplicated SQL-based retrieval logic from deprecated helper methods and turned those methods into thin compatibility wrappers that emit deprecation warnings.
  • Updated related sample store and discovery space manager code paths to use the unified retrieval flow.
  • Adjusted tests to validate the new calling pattern and explicitly assert deprecation warnings for legacy methods.

Impact

This change reduces duplicate retrieval code, standardizes entity loading behavior around a single API, and makes the deprecation path for old sample store access methods explicit. Existing deprecated methods still work for now, but downstream code should migrate to get_entities().

AI Disclosure

The code and this PR description were generated using IBM Bob (https://bob.ibm.com/) and were reviewed manually.

@AlessandroPomponio AlessandroPomponio added the ci Enables CI integration label Jul 24, 2026
@AlessandroPomponio
AlessandroPomponio marked this pull request as draft July 24, 2026 10:12
auto-merge was automatically disabled July 24, 2026 10:12

Pull request was converted to draft

…_entities

Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
@AlessandroPomponio
AlessandroPomponio force-pushed the ap_1270_deprecate_old_fetch_entities_methods branch from 02deb81 to fa3caf0 Compare July 27, 2026 12:07
Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
@AlessandroPomponio
AlessandroPomponio marked this pull request as ready for review July 27, 2026 13:14
@AlessandroPomponio
AlessandroPomponio added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit e9f980a Jul 28, 2026
18 checks passed
@AlessandroPomponio
AlessandroPomponio deleted the ap_1270_deprecate_old_fetch_entities_methods branch July 28, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Enables CI integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(core): consolidate entity-fetching through get_entities and deprecate legacy lookup methods

2 participants